[BUG]: thrust::zip_iterator allows out-of-bounds access if first iterator is longer than the others

[Jacobfaib]

Is this a duplicate?

• I confirmed there appear to be no duplicate issues for this bug and that I agree to the Code of Conduct

Type of Bug

Runtime Error

Component

Thrust

Describe the bug

Out of bounds access when the first iterator in a zip_iterator is longer than the others

How to Reproduce

// clang++ -I/path/to/thrust thrust_bug.cpp -o thrust_bug && ./thrust_bug
#include <thrust/iterator/zip_iterator.h>
#include <thrust/tuple.h>

#include <vector>
#include <iostream>

int main()
{
  std::vector<int> v(4, 0); // change me to 5!
  std::vector<int> y(4, 1);

  auto zip_begin = thrust::make_zip_iterator(thrust::make_tuple(v.begin(), y.begin()));
  auto zip_end   = thrust::make_zip_iterator(thrust::make_tuple(v.end(), y.end()));

  for (auto it = zip_begin; it != zip_end; ++it) {
    // BOOM out of bounds
    std::cout << "[" << thrust::get<0>(*it) << ", " << thrust::get<1>(*it) << "]" << std::endl; 
  }
}

Note the size of v and y are equal. If, however, you change v to be size 5

-   std::vector<int> v(4, 0);
+   std::vector<int> v(5, 0);

You will find that the iterator runs out of bounds.

Expected behavior

No out of bounds

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

[github-actions]

Hi @Jacobfaib!

Thanks for submitting this issue - the CCCL team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.