Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Backport the CI to the 11.8.x branch #275

Open
leofang opened this issue Dec 7, 2024 · 1 comment
Open

CI: Backport the CI to the 11.8.x branch #275

leofang opened this issue Dec 7, 2024 · 1 comment
Assignees
Labels
CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do

Comments

@leofang
Copy link
Member

leofang commented Dec 7, 2024

  • Strip the steps building cuda.core; let's build cuda.bindings only
  • By the time the test CI is ready, we test cuda.bindings (11.8.x) built in this branch + cuda.core built in the main branch (since we do not need to back port cuda.core changes)
@leofang leofang added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do labels Dec 7, 2024
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Dec 7, 2024
@leofang
Copy link
Member Author

leofang commented Dec 8, 2024

I think perhaps back porting is overkill. Looking at the current CI trigger conditions:

on:
push:
branches:
- "pull-request/[0-9]+"
- "main"

  • For PR: any changes in a PR targeting the 11.8.x branch should also trigger the pipeline
  • After PR merge: We probably can just add the 11.8.x branch there, so that the post merge artifacts can be produced.

Another thing is we'll need to use a different CTK version based on the target branch. GHA should have a way for us to detect it inside the workflow or action.

@leofang leofang changed the title Backport the CI to the 11.8.x branch CI: Backport the CI to the 11.8.x branch Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do
Projects
None yet
Development

No branches or pull requests

2 participants