Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change when form parts go to files #518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

randy909
Copy link

Rather than copy all form values to temp files when they have a content
type defined, only copy when they specify a filename or when the
content type is "application/octet-stream". Otherwise leave them as
"normal" key-value pairs also using the charset to construct the strings.

Rather than copy all form values to temp files when they have a content
type defined, only copy when they specify a filename or when the
content type is "application/octet-stream". Otherwise leave them as
"normal" key-value pairs also using the charset to construct the strings.
@LordFokas
Copy link
Member

It's been a long time since that file stopped existing. You should have pulled the current master before making the changes, now you have a conflict on your hands.

Also you should change the partIsFile() method to protected, a user might want to override that logic some time later (for example, to only dump to disk files bigger than a certain size or to dump some relevant non-file data into files automatically)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants