From 19c5d17a5d71134bd774496a80d43fe13184ba09 Mon Sep 17 00:00:00 2001
From: Ankit Jain <radical@gmail.com>
Date: Mon, 26 Sep 2022 04:26:31 -0400
Subject: [PATCH] perf-pipeline: Remove unnecessary jobs (#76111)

* perf-pipeline: Set default value for ExtraSetupArguments

Fixes `line 1: ExtraSetupArguments: command not found` when running
performance/scripts/ci_setup.py .

* perf pipeline: Disable unncessary scheduled builds

`dotnet-runtime-perf` runs:
1. batched builds
2. scheduled builds at 2:30am every night

For the 'scheduled' case, only wasm/jsc perf jobs are run.
And the rest are build jobs - wasm, mono, coreclr, and libraries.

The wasm/jsc runs are known to be broken right now, thus they can be
disabled. And since there are no other perf jobs, none of the remaining
builds are needed, thus the whole scheduled run can be disabled.

* perf-pipeline: Collect logs file from perf runs on dotnet-runtime-perf also
---
 eng/pipelines/coreclr/perf.yml                | 22 +++++++++++++------
 .../coreclr/templates/run-scenarios-job.yml   |  1 +
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/eng/pipelines/coreclr/perf.yml b/eng/pipelines/coreclr/perf.yml
index f1dfcce46c2b5..910c6a39df99f 100644
--- a/eng/pipelines/coreclr/perf.yml
+++ b/eng/pipelines/coreclr/perf.yml
@@ -20,18 +20,26 @@ trigger:
 variables:
   - template: /eng/pipelines/common/variables.yml
 
-schedules:
-- cron: "30 2 * * *"
-  displayName: Every night at 2:30AM
-  branches:
-    include:
-    - main
-  always: true
+#
+# For the 'schedule' case, only wasm/jsc perf jobs are run.
+# And the rest are build jobs - wasm, mono, coreclr, and libraries.
+#
+# Since, we are not running *any* perf jobs, none of these builds are needed,
+# thus the whole scheduled run can be disabled.
+#
+#schedules:
+#- cron: "30 2 * * *"
+  #displayName: Every night at 2:30AM
+  #branches:
+    #include:
+    #- main
+  #always: true
 
 jobs:
 
 - template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
   parameters:
+    collectHelixLogsScript: ${{ variables._wasmCollectHelixLogsScript }}
     ${{ and(ne(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'Schedule')) }}:
       runProfile: 'non-v8'
     ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'Schedule')) }}:
diff --git a/eng/pipelines/coreclr/templates/run-scenarios-job.yml b/eng/pipelines/coreclr/templates/run-scenarios-job.yml
index 8e9f29666efd2..d1ab982a1df25 100644
--- a/eng/pipelines/coreclr/templates/run-scenarios-job.yml
+++ b/eng/pipelines/coreclr/templates/run-scenarios-job.yml
@@ -107,6 +107,7 @@ jobs:
         - AdditionalHelixPreCommands: $(HelixPreCommandOSX)
         - AdditionalHelixPostCommands: $(HelixPostCommandOSX)
 
+    - ExtraSetupArguments: ''
     - name: ExtraSetupArguments
       ${{ if ne(parameters.runtimeType, 'wasm') }}:
         value: --install-dir $(PayloadDirectory)/dotnet