Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LW3 protocol handling, implement source selection and player state #6

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

Jalle19
Copy link
Contributor

@Jalle19 Jalle19 commented Sep 10, 2024

Now we're getting close to something being usable!

@Jalle19 Jalle19 requested a review from Esgrove September 10, 2024 10:37
Copy link
Contributor

@Esgrove Esgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Can't comment much on the logic itself since not familiar with this system

.github/workflows/unittest.yaml Outdated Show resolved Hide resolved
.github/workflows/unittest.yaml Outdated Show resolved Hide resolved
custom_components/vinx/lw3.py Outdated Show resolved Hide resolved
custom_components/vinx/lw3.py Outdated Show resolved Hide resolved
@Jalle19
Copy link
Contributor Author

Jalle19 commented Sep 11, 2024

@Esgrove thanks for the review!

@Jalle19 Jalle19 merged commit 3117c60 into main Sep 11, 2024
2 checks passed
@Jalle19 Jalle19 deleted the command-envelope branch September 11, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants