Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] editing character status #28

Closed
cavemccoy opened this issue Mar 11, 2021 · 5 comments
Closed

[feature request] editing character status #28

cavemccoy opened this issue Mar 11, 2021 · 5 comments
Labels
enhancement New feature or request not planed This feature is not planned at the moment

Comments

@cavemccoy
Copy link

Would it be possible to integrate a character status editor? I was recently resurrecting a character, and while I could edit their vitality, magic armor, and physical armor using the character tree editor (maybe this could be a slider in the main window... :D), I couldn't remove their "DYING" status. I had to manually unpack the file, and remove the nodes (StatusMeta and STATUS), since you can't remove nodes in GlEd. The .lsf file I ended up creating made DoS2 crash, but reopening it in GlEd, then resaving it and letting it do the conversion fixed it.

All that would be required for the editor to change status would be editing the following on a character's tree:

children -> note[id=StatusManager] -> children -> node[id=StatusMeta]
and the corresponding
children -> note[id=StatusManager] -> children -> node[id=STATUS]

You can double check that they refer to the same status by checking each one's "value" in attribute[id=ID].

This would allow removing burning, necrofire, dying, etc. without having to manually edit the file.

Thanks for making GlEd, it's really useful.

@NovFR
Copy link
Owner

NovFR commented Mar 11, 2021

Normally, you can remove a node or an attribute by hitting the Del key.

For the status editor, I'll see what I can do. Can take some time since I'm not very active at the moment.

@NovFR NovFR added the enhancement New feature or request label Mar 11, 2021
@cavemccoy
Copy link
Author

Ah, you're right, I didn't figure that out. Thanks! Your work is appreciated.

@NovFR
Copy link
Owner

NovFR commented Mar 12, 2021

I made some tests and it appears that removing the DYING status from the character is not enough to really revive it, even if you change the vitality amount. The character is "alive" but invulnerable and can't use any skills.

I'm therefore not sure it is a good idea to make changes in the StatusManager.

@qiuyang1008
Copy link

qiuyang1008 commented Mar 25, 2021

NPCs Resurrected by the skill Resurrect of Alexandar are "alive" but can't be communicated with any more.
There should be more than one variable in the Status or anywhere.

@NovFR NovFR added the not planed This feature is not planned at the moment label Mar 25, 2021
@NovFR
Copy link
Owner

NovFR commented Mar 25, 2021

I'll keep the request in mind, until I found a way to edit status without breaking anything.

@NovFR NovFR closed this as completed Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not planed This feature is not planned at the moment
Projects
None yet
Development

No branches or pull requests

3 participants