Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behaviour for static AD (Manni et.al 2011) #26

Open
VikingScientist opened this issue Jan 17, 2019 · 1 comment
Open

Wrong behaviour for static AD (Manni et.al 2011) #26

VikingScientist opened this issue Jan 17, 2019 · 1 comment

Comments

@VikingScientist
Copy link
Contributor

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>                        
                                                                               
<simulation>                                                                   
                                                                               
  <!-- General - geometry definitions !-->                                     
  <geometry dim="2" sets="True">                                               
    <raiseorder patch="1" u="2" v="2"/>                                        
    <refine type="uniform" patch="1" u="9" v="9"/>                             
    <topologysets/>                                                            
  </geometry>                                                                  
                                                                               
  <!-- General - boundary conditions !-->                                      
  <boundaryconditions>                                                         
    <dirichlet set="Boundary" comp="1"/>                                       
  </boundaryconditions>                                                        
                                                                               
  <discretization>                                                             
    <nGauss> 5 </nGauss>                                                       
  </discretization>                                                            
                                                                               
  <!-- Problem-specific block !-->                                             
  <advectiondiffusion>                                                         
    <advectionfield>1|0</advectionfield>                                       
    <!--                                                                       
    <stabilization> supg </stabilization>                                      
    <reactionfield> 1 </reactionfield>                                         
    -->                                                                        
    <source type="expression">2*x*cos(PI*y)</source>                           
    <kappa> 1e-2 </kappa>                                                      
  </advectiondiffusion>                                                        
                                                                               
  <postprocessing>                                                             
    <vtfformat nviz="2">ascii</vtfformat>                                      
  </postprocessing>                                                            
                                                                               
</simulation>                                                                  

Two immedate errors:

  • The resulting solution field looks like it is using stabilization (I requested no stabilization)
  • The resulting solution field has the wrong magnitude: 0.02, I was expecting 0.6
@VikingScientist
Copy link
Contributor Author

Three fixes:

  1. Syntax error on stabilization term. It should be formatted as
<stabilization type="supg"/>
  1. Also <kappa> should be wrapped into a <fluidproperties> tag.

  2. The SUPG stabilization is for some reason scaled by Xi in https://github.com/OPM/IFEM-AdvectionDiffusion/blob/master/AdvectionDiffusion.C#L253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant