Microoptimizations causing out-of-bounds writes

[akva2]

Some micro-optimalizations in opm-porsol are having unforseen consequences. To avoid reallocating cell-level entities for each cell, these entities are reused across cells with size according to the cell with the most DOFs attached.

the problem is that code further down the line assumes that these have the same size as the number of faces for a particular cell. for complex meshes, this is not a constant, and out of bounds writes is the consequence. in particular, the out of bounds writes happen in IncompFlowSolverHybrid.hpp, computePressureAndFluxes and buildCellContrib.

people are already on top of this (PR#89 was a first attempt), but i was asked to open this issue for tracking purposes, so here it is.

[bska]

Thanks for starting this discussion. I have a candidate solution in my (new) fix-out-of-bounds-indexing branch at https://github.com/bska/opm-porsol. I think this solves the same issues as the previous PR #89, but additionally also solves the computePressureAndFluxes() problem.

Would you or anyone else care to test it?

[akva2]

seems to do the job just fine.

[bska]

seems to do the job just fine.

Thanks for testing. PR #92 contains the solution.

[bska]

PR #92 was merged into master. I take it this issue can be closed?

[akva2]

indeed. thanks for your work on this

[bska]

indeed [this issue can be closed]

Thanks. I was honestly hoping issue 91 would be closed automatically by GitHub upon merging #92, but it seems I used the wrong command word (https://help.github.com/articles/closing-issues-via-commit-messages).