Fix no file or directory error on snapshot creation (qdrant#2720)

* remove temp files from archive

* fmt

* Undo revert "Remove one layer of tmp folder for shards" (qdrant#2683)

Remove one layer of tmp folder for shards

Unicity of segment tmp folder provided by Uuid

---------

Co-authored-by: Arnaud Gourlay <[email protected]>

Author: generall

lib/collection/src/collection.rs

@@ -1606,44 +1606,52 @@ impl Collection {
         );
 
         // Dedicated temporary directory for this snapshot (deleted on drop)
-        let snapshot_temp_dir = tempfile::Builder::new()
-            .prefix(&format!("{snapshot_name}-temp-"))
+        let snapshot_temp_target_dir = tempfile::Builder::new()
+            .prefix(&format!("{snapshot_name}-target-"))
             .tempdir_in(global_temp_dir)?;
-        let snapshot_temp_dir_path = snapshot_temp_dir.path().to_path_buf();
+
+        let snapshot_temp_target_dir_path = snapshot_temp_target_dir.path().to_path_buf();
         // Create snapshot of each shard
         {
+            let snapshot_temp_temp_dir = tempfile::Builder::new()
+                .prefix(&format!("{snapshot_name}-temp-"))
+                .tempdir_in(global_temp_dir)?;
             let shards_holder = self.shards_holder.read().await;
             // Create snapshot of each shard
             for (shard_id, replica_set) in shards_holder.get_shards() {
                 let shard_snapshot_path =
-                    versioned_shard_path(&snapshot_temp_dir_path, *shard_id, 0);
+                    versioned_shard_path(&snapshot_temp_target_dir_path, *shard_id, 0);
                 create_dir_all(&shard_snapshot_path).await?;
                 // If node is listener, we can save whatever currently is in the storage
                 let save_wal = self.shared_storage_config.node_type != NodeType::Listener;
                 replica_set
-                    .create_snapshot(&snapshot_temp_dir_path, &shard_snapshot_path, save_wal)
+                    .create_snapshot(
+                        snapshot_temp_temp_dir.path(),
+                        &shard_snapshot_path,
+                        save_wal,
+                    )
                     .await?;
             }
         }
 
         // Save collection config and version
-        CollectionVersion::save(&snapshot_temp_dir_path)?;
+        CollectionVersion::save(&snapshot_temp_target_dir_path)?;
         self.collection_config
             .read()
             .await
-            .save(&snapshot_temp_dir_path)?;
+            .save(&snapshot_temp_target_dir_path)?;
 
         // Dedicated temporary file for archiving this snapshot (deleted on drop)
         let mut snapshot_temp_arc_file = tempfile::Builder::new()
             .prefix(&format!("{snapshot_name}-arc-"))
             .tempfile_in(global_temp_dir)?;
 
         // Archive snapshot folder into a single file
-        log::debug!("Archiving snapshot {:?}", &snapshot_temp_dir_path);
+        log::debug!("Archiving snapshot {:?}", &snapshot_temp_target_dir_path);
         let archiving = tokio::task::spawn_blocking(move || {
             let mut builder = TarBuilder::new(snapshot_temp_arc_file.as_file_mut());
             // archive recursively collection directory `snapshot_path_with_arc_extension` into `snapshot_path`
-            builder.append_dir_all(".", &snapshot_temp_dir_path)?;
+            builder.append_dir_all(".", &snapshot_temp_target_dir_path)?;
             builder.finish()?;
             drop(builder);
             // return ownership of the file

lib/collection/src/shards/local_shard.rs

@@ -23,7 +23,6 @@ use tokio::fs::{copy, create_dir_all, remove_dir_all};
 use tokio::runtime::Handle;
 use tokio::sync::mpsc::Sender;
 use tokio::sync::{mpsc, oneshot, Mutex, RwLock as TokioRwLock};
-use uuid::Uuid;
 use wal::{Wal, WalOptions};
 
 use super::update_tracker::UpdateTracker;
@@ -573,8 +572,7 @@ impl LocalShard {
             rx.await?;
         }
 
-        let temp_path = temp_path.join(format!("shard-{}", Uuid::new_v4()));
-        create_dir_all(&temp_path).await?;
+        let temp_path = temp_path.to_owned();
 
         tokio::task::spawn_blocking(move || {
             let segments_read = segments.read();