Players incorrectly being reported as observers in BWAPI 4.2.0 clients

[Jabbo16]

This code called at onStart() while running a Melee game mode match:

for(Player p : bw.getAllPlayers()) {
    System.out.println("playername: " + p.getName() + " is observer: " + p.isObserver());
}

Returns all players as being observers:

playername: Cronus Wing is observer: true
playername: bwapi is observer: true
playername: Neutral is observer: true

The only Player that should be observer is Neutral.

[adakitesystems]

Thanks for the bug report.

Confirmed. However, in Linux + OpenBW + BWAPI4J, these players are not reported as observers. I suspect something to do with the bridge for Windows. Looking into recompiling the bridge. The values seem to be getting set correctly:

intBuf[index++] = player->isObserver() ? 1 : 0;

and

this.isObserver = playerData[index + Player.IS_OBSERVER_INDEX] == 1;

[adakitesystems]

Update:

• Recompiling the bridge for Windows did not resolve the issue.
• As a manual debug test, changing intBuf[index++] = player->isObserver() ? 1 : 0; to intBuf[index++] = player->isObserver() ? 0 : 0; in the Windows bridge resulted in the players being correctly reported as isObserver() == false.
• Somehow, the Windows bridge is reporting the incorrect value but the Linux bridge appears to report the correct value.

Update 2:

• I reverted to a very old commit aca6040 and observed the same issue.

[Jabbo16]

Shouldnt the code be:

intBuf[index++] = player->isObserver() == 1 ? 1 : 0

BWAPI isObserver() method returns 1 if observer and 0 if not.

[adakitesystems]

PlayerInterface.isObserver() in C++ is a bool function. That is the correct syntax. Even if it wasn't a bool, that is still valid syntax. I tried with == 1 anyway and observed the same incorrect behavior.

[Jabbo16]

Ok, then forget what I said.

What a weird behaviour.

[adakitesystems]

Using a completely separate C++ BWAPI 4.2.0 client project with no Java, I am getting the same incorrect behavior with the client version but not with the module version. @Jabbo16, can you verify this as well, please?

[Jabbo16]

I checked module before and got correct behaviour, both players reported as not observers, just the Neutral player as observer.

Looks like Client bug?

[adakitesystems]

Yes, it looks like a BWAPI client bug that is present in 4.2.0, 4.1.2, and maybe other versions. The module appears unaffected. If/when it gets fixed, someone (if I'm not around) should use the updated BWAPI libs to recompile the bridge and then close this issue.

[adakitesystems]

This issue has been fixed in the develop branch of C++ BWAPI. When an official version is released with this fix, the BWAPI4JBridge just needs to update to the new BWAPI version and recompile the bridge. Then, this issue can be closed.

[adakitesystems]

Upgraded to BWAPI v4.4.0 in 83423a9 which should resolve this. Needs to be tested first.