Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing UnitCommand #81

Open
Jabbo16 opened this issue Nov 2, 2018 · 5 comments
Open

Missing UnitCommand #81

Jabbo16 opened this issue Nov 2, 2018 · 5 comments
Labels
missing A feature is absent from BWAPI4J but not the original C++ BWAPI. pending merge A fix has been proposed but is awaiting approval, review, or a merge from another branch.

Comments

@Jabbo16
Copy link
Contributor

Jabbo16 commented Nov 2, 2018 •
edited
Loading

I noticed some bots use UnitCommand for micro and order spam checks but It seems that in BWAPI4J there is only UnitCommandType available with getLastCommand.
@adakitesystems
Copy link
Collaborator

Do you have a specific example? I think UnitCommand was intentionally left out because UnitCommand is basically UnitCommandType + Order + OrderTarget, etc. I haven't looked at it too closely, though.

@dgant
Copy link
Collaborator

dgant commented Nov 2, 2018 •
edited
Loading

UnitCommand reflects what was sent to the game engine via BWAPI. Orders reflect the state of the game engine.

UnitCommands are a nice-to-have, but their functionality can be reproduced by BWAPI4J consumers without the aid of the framework (ie. track what commands you issue).

@Jabbo16
Copy link
Contributor Author

Jabbo16 commented Nov 2, 2018

Its easier to use UnitCommands than to track orders 😅

@adakitesystems
Copy link
Collaborator

Fair enough. I'll look into some time and see what can be done.

@adakitesystems adakitesystems added the missing A feature is absent from BWAPI4J but not the original C++ BWAPI. label Nov 2, 2018
@adakitesystems adakitesystems added the pending merge A fix has been proposed but is awaiting approval, review, or a merge from another branch. label Nov 19, 2018
@adakitesystems
Copy link
Collaborator

UnitCommand.java has been implemented in the raw interface. This issue can be closed after raw is merged into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing A feature is absent from BWAPI4J but not the original C++ BWAPI. pending merge A fix has been proposed but is awaiting approval, review, or a merge from another branch.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgant @Jabbo16 @adakitesystems