Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 1: 01_introduction/03_molecular_dynamics.ipynb broken with 2023.4 #17

Closed
jmichel80 opened this issue Dec 6, 2023 · 7 comments

Comments

@jmichel80
Copy link
Contributor

I am re-runnning all tutorials on try.openbiosim.org as part of finalising the revisions to the tutorials suite paper

The following tutorial https://github.com/OpenBioSim/biosimspace_tutorials/blob/main/01_introduction/03_molecular_dynamics.ipynb

fails with a runtime error at the last cell if the selected backend is MDTRAJ

image

The backends mdanalysis and sire behave as expected.

@lohedges
Copy link
Contributor

lohedges commented Dec 7, 2023

Thanks, I'll take a look. There's a unit test for this, so surprising that it's failing.

@lohedges
Copy link
Contributor

lohedges commented Dec 7, 2023

It works fine for me using the latest development version of the code.

rmsd

Note that the cell that is supposedly returning a trajectory in mdtraj format will need to be updated to:

mdtraj = traj.getTrajectory(format="mdtraj")

The default has been changed to "auto", which will use the first backend that works, which in this case is Sire.

@lohedges
Copy link
Contributor

lohedges commented Dec 7, 2023

Looking at the history of the trajectory code I don't see any updates related to what you are seeing. It looks like the specified backend is being ignored and Sire is being used instead, e.g. it's effectively using "auto" rather than "mdtraj". (This could be the case if the mdtraj install is borked for some reason.)

@jmichel80
Copy link
Contributor Author

Very strange. I cannot reproduce the error with the code update

mdtraj = traj.getTrajectory(format="mdtraj")

before execution of the rmsd plot cell.

@lohedges
Copy link
Contributor

lohedges commented Dec 7, 2023

Ah, interesting. I'll check that. It could be that it sets the backend the first time you use it, then isn't updating when you specify it a second time, i.e. it was using Sire both times.

@lohedges
Copy link
Contributor

lohedges commented Dec 7, 2023

Yes, that's the issue. It doesn't seem to swap the backend the second time you call .getTrajectory. I'll fix this now.

@lohedges
Copy link
Contributor

lohedges commented Dec 7, 2023

Now fixed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants