Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OpenKinect/libfreenect
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: serial
Choose a base ref
...
head repository: OpenKinect/libfreenect
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 17 files changed
  • 4 contributors

Commits on Apr 3, 2023

  1. build(python): remove outdated precompiled extension 

    Signed-off-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8f5ba39 View commit details
    Browse the repository at this point in the history

  2. Don't raise unless exception occurs. 

    This commit adds a check before `raise last_error`.

`last_error` could still be `None`, in which case `raise None` itself throws an exception, which is probably not what you want.

Co-authored-by: Benn Snyder <[email protected]>
Signed-off-by: Benn Snyder <[email protected]>
Reviewed-by: Benn Snyder <[email protected]>
    @scovetta @piedar
    scovetta and piedar committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    478b68b View commit details
    Browse the repository at this point in the history

  3. Added manual exposure settings 

    Co-authored-by: Benn Snyder <[email protected]>
Signed-off-by: Benn Snyder <[email protected]>
Reviewed-by: Benn Snyder <[email protected]>
    @dudeofea @piedar
    dudeofea and piedar committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    0f8d11e View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2024

  1. fix(python): add noexcept to callbacks to fix #673 

    Signed-off-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    5341ff6 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Use the recommended way to integrate Cython and NumPy 

    This follows the example code in
<https://cython.readthedocs.io/en/latest/src/tutorial/numpy.html#adding-types>.

The previous version results in an int-conversion error with current
compilers:

…-build/wrappers/python/freenect3.c:16598:3: error: returning ‘void *’ from a function with return type ‘int’ makes integer from pointer without a cast
16598 |   import_array();
      |   ^~~~~~~~~~~~
    @fweimer-rh
    fweimer-rh committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    933c4ed View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. fix(python): use legacy_implicit_noexcept to support old cython and fix 

    #680

Signed-off-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a9806d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. build: remove deprecated cmake features 

    Signed-off-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    6f64284 View commit details
    Browse the repository at this point in the history

  2. build(examples): link to specific opengl targets 

    Signed-off-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    00b4308 View commit details
    Browse the repository at this point in the history

  3. refactor(examples): reduce dependencies on glu 

    Signed-off-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    0e2fd22 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'fweimer-rh/c99' 

    Signed-off-by: Benn Snyder <[email protected]>
Reviewed-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    196f95d View commit details
    Browse the repository at this point in the history

  5. build(python): properly support both new and old cython 

    Signed-off-by: Benn Snyder <[email protected]>
    @piedar
    piedar committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    09a1f09 View commit details
    Browse the repository at this point in the history
Loading