Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for classes which have the Interface IteratorAggregate but not Countable #619

Open
Flyingmana opened this issue Mar 11, 2019 · 2 comments

Comments

@Flyingmana
Copy link
Contributor

Follow up to #604

Look for cases where the Interface IteratorAggregate but not Countable is added.
Then add the Countable in case it has a count() method, and if not list the class here for discussion.

@Flyingmana Flyingmana added the good first issue easy to solve issues label Mar 11, 2019
@sreichel
Copy link
Contributor

sreichel commented Apr 15, 2019

Hope this belongs here ....

Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/xyz/public_html/.modman/xyz/src/app/design/frontend/default/xyz/template/shipping/tracking/popup.phtml on line 130

It's a ustom Theme, but code is nearly the same as in vanilla ...

https://github.com/OpenMage/magento-lts/blob/1.9.4.x/app/design/frontend/base/default/template/shipping/tracking/popup.phtml#L131

Can some reproduce when open tracking-URL popup?

@seansan
Copy link
Contributor

seansan commented Apr 15, 2019 via email

@kkrieger85 kkrieger85 added the work in progress For Pull Requests which still have changes planned label Jun 2, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 22, 2019
…ions

* Mage_Sales_Model_Entity_Sale_Collection
* Zend_Db_Table_Row_Abstract
* Zend_Db_Statement_Pdo
* Zend_Rest_Client_Result
* Zend_Rest_Client_Result
* Zend_TimeSync

refs: OpenMage#619
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Oct 25, 2019
…ions

* Mage_Sales_Model_Entity_Sale_Collection
* Zend_Db_Table_Row_Abstract
* Zend_Db_Statement_Pdo
* Zend_Rest_Client_Result
* Zend_Rest_Client_Result
* Zend_TimeSync

refs: OpenMage#619
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 20, 2020
…ions

* Mage_Sales_Model_Entity_Sale_Collection
* Zend_Db_Table_Row_Abstract
* Zend_Db_Statement_Pdo
* Zend_Rest_Client_Result
* Zend_Rest_Client_Result
* Zend_TimeSync

refs: OpenMage#619
@addison74 addison74 added waiting for feedback PR requested and removed good first issue easy to solve issues work in progress For Pull Requests which still have changes planned labels Jun 2, 2022
@addison74 addison74 changed the title check for classes which have the Interface IteratorAggregate but not Countable Check for classes which have the Interface IteratorAggregate but not Countable Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants