EAV attribute condition SQL is not escaped by quoteIdentifier method for the filtered fields

[kanevbg]

Eg, it generates attribute aliases without apostrophes:

WHERE (`e`.`attribute_set_id` = '10') AND (at_fmfid.value != '') AND (at_sgid.value != '') AND (at_44-01.value = 200233)

instead of:

WHERE (`e`.`attribute_set_id` = '10') AND (`at_fmfid`.`value` != '') AND (`at_sgid`.`value` != '') AND (`at_44-01`.`value` = 200233)

The second example is the proper and the reliable one according to MySQL syntax.

The bug is on line: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php:1388

$field = $this->_getAttributeTableAlias($attribute) . '.value';

which should be:
$field = $this->getConnection()->quoteIdentifier($this->_getAttributeTableAlias($attribute) . '.value');

[colinmollenhour]

Agreed, would you submit a PR, please?

[addison74]

@kanevbg - If this is a bug in OpenMage please submit a PR for being tested. Thank you.