Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivacyManagerService change #5

Open
mateor opened this issue Jan 30, 2013 · 1 comment
Open

PrivacyManagerService change #5

mateor opened this issue Jan 30, 2013 · 1 comment

Comments

@mateor
Copy link
Member

mateor commented Jan 30, 2013

The move to 'final' in the smali broke the recompile of the framework.jar with this message

 tmp/system/framework/framework.jar.out/smali/android/privacy/PrivacySettingsManagerService.smali[0,-1] mismatched input '<EOF>' expecting END_METHOD_DIRECTIVE

I reverted the commit here: mateor/auto-patcher@1fd613e

You can close this issue whenever you read this as it has been rectified (although I guess the original bug is back in the PDroid code. Up to you if you want to play with it.)

@wsot
Copy link

wsot commented Feb 11, 2013

Yeah, we're going to have to put that 'final' through at some point - otherwise it is possible to override the PrimacySettingsManagerService in the PrivacySettingsManager object, and that can be used to force 'allow' responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants