Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware with userId function doesn't handle unathorized case #80

Open
shedar opened this issue Dec 5, 2014 · 0 comments
Open

Middleware with userId function doesn't handle unathorized case #80

shedar opened this issue Dec 5, 2014 · 0 comments

Comments

@shedar
Copy link

shedar commented Dec 5, 2014

Middleware supports function as userId, but it doesn't work in case if function returns undefined (user not authorized).

My suggestion is to add check for undefined after retrieving of _userId (https://github.com/OptimalBits/node_acl/blob/master/lib/acl.js#L520) and throw 401 if _userId is undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant