Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS handling in the proxy #6

Open
dieppe opened this issue Oct 6, 2014 · 11 comments
Open

Add CORS handling in the proxy #6

dieppe opened this issue Oct 6, 2014 · 11 comments
Assignees

Comments

@dieppe
Copy link

dieppe commented Oct 6, 2014

Hi,

Thanks for the great work on redbird, we've been using it in production for about 2 weeks, and we're quite happy with it 🍻, especially the HTTPs support is great!

The only problem we had, that is more an annoyance than a bug, is that we had to disable redirect because it is not compatible with CORS, since the 302 headers do not have any CORS information.

Would it be possible to add support for CORS inside redbird? That would be most appreciated (and useful).

Thanks!

@manast manast self-assigned this Oct 6, 2014
@manast
Copy link
Member

manast commented Oct 6, 2014

ok, I will look into it.

@manast
Copy link
Member

manast commented Oct 7, 2014

I will integrate this library: https://github.com/troygoode/node-cors in redbird for complete CORS support.

@dieppe
Copy link
Author

dieppe commented Oct 7, 2014

Thank you for your quick answer. I think the most important bit is CORS preflight (at least for http -> https redirect).

@dieppe
Copy link
Author

dieppe commented Oct 14, 2014

Sorry, I was wrong, I think preflight has nothing to do with http to https redirect.

@cgarvis
Copy link

cgarvis commented Feb 12, 2015

+1

@eladh
Copy link

eladh commented Sep 14, 2016

Hi @manast .

Just wanted to know if this issue will be implemented soon ?

if any help needed - just say .

best regards,
elad.

@manast
Copy link
Member

manast commented Sep 14, 2016

@eladh I do not have the requirement myself so I do not really know where to start :) You are welcome to help if you want to.

@joernroeder
Copy link

the readme says there is cors support but there isn't. any updates on this?

@lopugit
Copy link

lopugit commented Mar 18, 2024

Any progress on this? 👀

Just want to add Access-Control-Allow-Origin: * to all requests

@lopugit
Copy link

lopugit commented Mar 18, 2024

Screenshot 2024-03-18 at 11 54 58 am

RIP 😂

@lopugit
Copy link

lopugit commented Mar 18, 2024

time for a PR 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants