Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use np.nanmean or other NaN-robust measures when applicable #1395

Closed
MauricePasternak opened this issue Feb 8, 2025 · 0 comments · Fixed by #1399
Closed

Use np.nanmean or other NaN-robust measures when applicable #1395

MauricePasternak opened this issue Feb 8, 2025 · 0 comments · Fixed by #1399
Labels
bug Issues noting problems and PRs fixing those problems.

Comments

@MauricePasternak
Copy link

Particularly noteworthy whenever framewise displacement and/or dvars comes up. For example, the output from fMRIPrep commonly features NaNs for the first row:

Image

This leads to downstream issues such as linc_qc reporting a missing value for mean_fd, the HTML reports reporting NaN:

Image

Currently present in v0.10.5.
@MauricePasternak MauricePasternak added the bug Issues noting problems and PRs fixing those problems. label Feb 8, 2025
@tsalo tsalo mentioned this issue Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make calculations robust to NaNs PennLINC/xcp_d
1 participant
@MauricePasternak