Sed usage in README build

[spirillen]

I come to wonder of the way you are building the README by using sed and executing 12 process for something I would expect could be one process,

Current script

Phishing.Database/ci/update.sh

Lines 331 to 343 in cbdf6cc

	cat "${CI_README_TEMPLATE}" | sed "s|%%version%%|${BUILD_NUMBER}|g" | \
	sed "s|%%testTime%%|${testTime}|g" | \
	sed "s|%%testDay%%|${testDay}|g" | \
	sed "s|%%testDate%%|${testDate}|g" | \
	sed "s|%%activeNowCount%%|${activeNowCount}|g" | \
	sed "s|%%activeTodayCount%%|${activeTodayCount}|g" | \
	sed "s|%%discoveredTodayCount%%|${discoveredTodayCount}|g" | \
	sed "s|%%domainsCount%%|${domainsCount}|g" | \
	sed "s|%%linksCount%%|${linksCount}|g" | \
	sed "s|%%domainsTGZSize%%|${domainsTGZSize}|g" | \
	sed "s|%%linksTGZSize%%|${linksTGZSize}|g" > "${README_FILE}"
	}

Expect to work as equal with only one process and run over the readme.template with sed

sed "s|%%version%%|${BUILD_NUMBER}|g;s|%%testTime%%|${testTime}|g;s|%%testDay%%|${testDay}|g;s|%%testDate%%|${testDate}|g;s|%%activeNowCount%%|${activeNowCount}|g;s|%%activeTodayCount%%|${activeTodayCount}|gs|%%discoveredTodayCount%%|${discoveredTodayCount}|g;s|%%domainsCount%%|${domainsCount}|g;s|%%linksCount%%|${linksCount}|g;s|%%domainsTGZSize%%|${domainsTGZSize}|g;s|%%linksTGZSize%%|${linksTGZSize}|g" "${CI_README_TEMPLATE}" > "${README_FILE}"

[spirillen]

Same here

Phishing.Database/ci/update.sh

Lines 347 to 353 in cbdf6cc

	function cleanupFiles() {
	# We now remove the original files.
	rm -f "${PHISHING_ALL_PHISHING_DOMAINS_FILE}"
	rm -f "${PHISHING_ALL_PHISHING_LINKS_FILE}"
	rm -f "${PHISHING_ALL_DOMAINS_FILE}"
	rm -f "${PHISHING_ALL_LINKS_FILE}"
	}

make this 1 process, there are no reason to start 4 process for what can be done in 1

rm -f "${PHISHING_ALL_PHISHING_DOMAINS_FILE}" "${PHISHING_ALL_PHISHING_LINKS_FILE}" "${PHISHING_ALL_DOMAINS_FILE}" "${PHISHING_ALL_LINKS_FILE}"

[spirillen]

as i comment 2, collect the same command to 1 process

Phishing.Database/ci/update.sh

Lines 295 to 299 in cbdf6cc

	# Cleanup the previous versions.
	rm -f "${PHISHING_ALL_PHISHING_DOMAINS_ZIP}"
	rm -f "${PHISHING_ALL_PHISHING_LINKS_ZIP}"
	rm -f "${PHISHING_ALL_DOMAINS_TGZ}"
	rm -f "${PHISHING_ALL_LINKS_TGZ}"

[spirillen]

abusive usage of rm again in

Phishing.Database/ci/update.sh

Lines 117 to 121 in cbdf6cc

	rm -f "${whitelistMeDestination}"
	rm -f "${whitelistMeRegexDestionation}"
	rm -f "${whitelistMeRZDDestination}"
	rm -f "${additionalDomainDestination}"
	rm -f "${additionalLinkDestination}"