Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokémon Cries #242

Open
tthverst opened this issue Jul 22, 2016 · 7 comments
Open

Pokémon Cries #242

tthverst opened this issue Jul 22, 2016 · 7 comments

Comments

@tthverst
Copy link

tthverst commented Jul 22, 2016

It would be pretty cool if the pokémon cries would be included in the API, I guess their implementation would be quite similar to how the sprites are implemented.

The response for endpoint http://pokeapi.co/api/v2/pokemon/1/ would then contain
a new key => value pair. Something like the code below:
"cry" : "http://pokeapi.co/media/sounds/pokemon/cry/1.ogg"

The first step would be to gather the resources for this, the sound files would need to have the appropriate format for web playback, so MP3, OGG, or WAV would be safe choices.

The link below is one I found, but there could be better ones out there so I would appreciate your input on this.

UPDATE: I added another link for the cries.

Resources

http://www.smogon.com/forums/threads/pok%C3%A9mon-xy-remastered-cries.3512615/
http://veekun.com/dex/downloads#other-files

@phalt
Copy link
Member

phalt commented Jul 22, 2016

Yeah I like that :)

@sotojuan
Copy link

sotojuan commented Aug 9, 2016

Should we only have the new cries, old ones when applicable, or both?

@tthverst
Copy link
Author

tthverst commented Aug 9, 2016

The veekun link has both old and new cries. So I guess we can do both.

@cgbsu
Copy link

cgbsu commented Apr 6, 2021

What would be the approach legally speaking?

What is the legal approach with sprites?

@Naramsim
Copy link
Member

Naramsim commented Apr 7, 2021

@cgbsu Your comment is a bit out of context. I redirect you here for your question: PokeAPI/sprites#38

@MiquelRForgeFlow
Copy link
Contributor

FYI here is an api for pokemon cries https://www.pkmnapi.com/endpoints/pokemon-cries/
@tthverst maybe you could add it in your initial post

@FallenDeity
Copy link
Contributor

FallenDeity commented Dec 24, 2023

Is work on having pokemon cries in the api still an option or has this idea been dropped if its fine I could make a pr for this
(PS: I think it's a great idea to have pokemon cries as an additional resource under the api)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants