Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Data for Aegislash. #635

Open
staticaron opened this issue Jul 21, 2021 · 6 comments
Open

No Data for Aegislash. #635

staticaron opened this issue Jul 21, 2021 · 6 comments

Comments

@staticaron
Copy link

Doublade's evolution and Honedge's final evolution named Aegislash doesn't have any data on the api.

Both Honedge and Doublade have their entries in the api.

Veekun's pokedex has the data and works perfectly.

Expected Behaviour:

The appropriate data should be send by the api.

Steps to Reproduce:

1.Search Aegislash on the api.

@C-Garza
Copy link
Member

C-Garza commented Jul 21, 2021

Aegislash does exist, but it has different forms so its endpoint isn't just Aegislash.

You could query by id or a specific form name like this:
https://pokeapi.co/api/v2/pokemon/681
https://pokeapi.co/api/v2/pokemon/aegislash-shield
https://pokeapi.co/api/v2/pokemon/aegislash-blade

@staticaron
Copy link
Author

@C-Garza thanks, but one of them ( Aegislash-Shield / Aegislash-Blade ) should have a reference to one another in the forms section like the veekun pokedex :
Screenshot_2021-07-21-13-50-36-25.jpg

In veekun pokedex, there is a entry for Aegislash which is Aegislash-Blade by default and references the other form.

The point is, no one knows to search Aegislash-Blade instead of Aegislash.

@Parnassius
Copy link

You can obtain the default form from the pokemon-species endpoint, in the varieties field: https://pokeapi.co/api/v2/pokemon-species/aegislash

@Kronopt
Copy link
Member

Kronopt commented Jul 24, 2021

The point is, no one knows to search Aegislash-Blade instead of Aegislash.

This is actually a pretty good point, one I've made in the past myself.
There are many issues referencing this quirk of pokeapi, and this probably won't be the last one.

Are there any issues in having a default variety for the Aegislash, instead of Aegislash-Blade, etc?

@Rrhapsod
Copy link

The same problem with Giratina. No one searches for giratina-origin

@staticaron
Copy link
Author

The same problem with Giratina. No one searches for giratina-origin

I have made a custom json file with all the correct references. You can cache this json into a dictionary to perform quick checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants