Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The algorithm derivation mentioned in the original paper does not match the algorithm itself. #29

Open
SmokerX opened this issue Nov 5, 2018 · 1 comment

Comments

@SmokerX
Copy link

SmokerX commented Nov 5, 2018

This code is one of the worst of the code series I have seen from the original author. Whether it's code correctness, operational efficiency, variable name naming, or code structure, there is nothing to be desired. It’s incredible that the original text of the paper is so clear and concise that it’s so badly implemented.

@SmokerX SmokerX changed the title 纯属吐槽 吐槽一下代码结构 Nov 5, 2018
@SmokerX
Copy link
Author

SmokerX commented Nov 5, 2018

c˜s = βc0 + (1 − β)cs, c0 ⊥ cs

论文第3页提到了这个公式。

然后论文第4页提到了
So assume that Zc˜s is roughly the same, say Z for all c˜s.

image

疑问点1:算法中红框部分的Vs是否就是论文第3页提到了这个公式中提到的c˜s

疑问点2: u·uT·Vs 是否对应的是c0

疑问点3:Vs-u·uT·Vs 是怎么和论文3的这个包含β的公式对应起来的,而且整个代码中,β也并没有用到。

@SmokerX SmokerX changed the title 吐槽一下代码结构 The algorithm derivation mentioned in the original paper does not match the algorithm itself. Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant