From ee393094de66786b3550610ce6515fa3b83227e3 Mon Sep 17 00:00:00 2001
From: tblivet <thibault.blivet@prestashop.com>
Date: Mon, 26 Jun 2023 17:11:39 +0200
Subject: [PATCH] fix: H4 semantic

---
 templates/catalog/_partials/customization-modal.tpl         | 4 ++--
 templates/catalog/_partials/product-customization-modal.tpl | 6 +++---
 templates/catalog/listing/product-list.tpl                  | 2 +-
 templates/catalog/product.tpl                               | 2 +-
 templates/checkout/_partials/address-selector-block.tpl     | 2 +-
 templates/checkout/_partials/order-final-summary.tpl        | 2 +-
 templates/checkout/order-confirmation.tpl                   | 2 +-
 templates/components/account-menu.tpl                       | 2 +-
 .../customer/_partials/account-transformation-form.tpl      | 2 +-
 templates/customer/_partials/block-address.tpl              | 2 +-
 templates/customer/order-detail.tpl                         | 4 ++--
 templates/errors/404.tpl                                    | 4 ++--
 templates/errors/410.tpl                                    | 2 +-
 templates/errors/not-found.tpl                              | 2 +-
 14 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/templates/catalog/_partials/customization-modal.tpl b/templates/catalog/_partials/customization-modal.tpl
index 2ca4e1bb8..32ac8c53c 100644
--- a/templates/catalog/_partials/customization-modal.tpl
+++ b/templates/catalog/_partials/customization-modal.tpl
@@ -2,9 +2,9 @@
   <div class="modal-dialog" role="document">
     <div class="modal-content">
       <div class="modal-header">
-        <h4 class="modal-title" id="myModalLabel">
+        <p class="fifth-title modal-title" id="myModalLabel">
           {l s='Product customization' d='Shop.Theme.Catalog'}
-        </h4>
+        </p>
         <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="{l s='Close' d='Shop.Theme.Global'}"></button>
       </div>
       <div class="modal-body">
diff --git a/templates/catalog/_partials/product-customization-modal.tpl b/templates/catalog/_partials/product-customization-modal.tpl
index 5ef3f58c6..3cd99195f 100644
--- a/templates/catalog/_partials/product-customization-modal.tpl
+++ b/templates/catalog/_partials/product-customization-modal.tpl
@@ -17,7 +17,7 @@
     <div class="modal-dialog modal-dialog-scrollable modal-fullscreen-sm-down">
       <div class="modal-content">
         <div class="modal-header">
-          <h4 class="modal-title">{l s='Product customization' d='Shop.Theme.Checkout'}</h4>
+          <p class="fifth-title modal-title">{l s='Product customization' d='Shop.Theme.Checkout'}</p>
           <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="{l s='Close' d='Shop.Theme.Global'}"></button>
         </div>
         <div class="modal-body">
@@ -62,10 +62,10 @@
   <div class="{$componentName}__popup">
     {foreach from=$image_modals item="image_modal"}
       <div class="modal fade" id="{$image_modal['id']}" tabindex="-1" aria-hidden="true">
-        <div class="modal-dialog modal-dialog-scrollable modal-fullscreen-sm-down mw-100">
+        <div class="modal-dialog modal-dialog-scrollable modal-fullscreen-sm-down">
           <div class="modal-content">
             <div class="modal-header">
-              <h4 class="modal-title">{$image_modal['title']}</h4>
+              <p class="fifth-title modal-title">{$image_modal['title']}</p>
               <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="{l s='Close' d='Shop.Theme.Global'}"></button>
             </div>
             <div class="modal-body">
diff --git a/templates/catalog/listing/product-list.tpl b/templates/catalog/listing/product-list.tpl
index 113b97e95..ff9689e15 100644
--- a/templates/catalog/listing/product-list.tpl
+++ b/templates/catalog/listing/product-list.tpl
@@ -40,7 +40,7 @@
 
         <div id="js-product-list">
           {capture assign="errorContent"}
-            <h4>{l s='No products available yet' d='Shop.Theme.Catalog'}</h4>
+            <p class="fourth-title">{l s='No products available yet' d='Shop.Theme.Catalog'}</p>
             <p>{l s='Stay tuned! More products will be shown here as they are added.' d='Shop.Theme.Catalog'}</p>
           {/capture}
 
diff --git a/templates/catalog/product.tpl b/templates/catalog/product.tpl
index b92153402..0109960e8 100644
--- a/templates/catalog/product.tpl
+++ b/templates/catalog/product.tpl
@@ -143,7 +143,7 @@
                     <div class="product__attachments accordion-body">
                       {foreach from=$product.attachments item=attachment}
                         <div class="attachment">
-                          <h4><a href="{url entity='attachment' params=['id_attachment' => $attachment.id_attachment]}">{$attachment.name}</a></h4>
+                          <p class="fifth-title"><a href="{url entity='attachment' params=['id_attachment' => $attachment.id_attachment]}">{$attachment.name}</a></p>
                           <p>{$attachment.description}</p>
                           <a href="{url entity='attachment' params=['id_attachment' => $attachment.id_attachment]}">
                             {l s='Download' d='Shop.Theme.Actions'} ({$attachment.file_size_formatted})
diff --git a/templates/checkout/_partials/address-selector-block.tpl b/templates/checkout/_partials/address-selector-block.tpl
index 986ed2beb..e4f0ba5b9 100644
--- a/templates/checkout/_partials/address-selector-block.tpl
+++ b/templates/checkout/_partials/address-selector-block.tpl
@@ -19,7 +19,7 @@
               <i class="form-check-round"></i>
             </span>
             <div class="address__content col-10">
-              <h4 class="address__alias card-title">{$address.alias}</h4>
+              <p class="address__alias fourth-title card-title">{$address.alias}</p>
               <address class="address__content">{$address.formatted nofilter}</address>
 
               {block name='address_block_item_actions'}
diff --git a/templates/checkout/_partials/order-final-summary.tpl b/templates/checkout/_partials/order-final-summary.tpl
index a2d4242ab..37ac74210 100755
--- a/templates/checkout/_partials/order-final-summary.tpl
+++ b/templates/checkout/_partials/order-final-summary.tpl
@@ -5,7 +5,7 @@
 
 <hr />
 <section id="order-summary-content" class="order__summary">
-  <h4 class="mb-4">{l s='Please check your order before payment' d='Shop.Theme.Checkout'}</h4>
+  <p class="fourth-title mb-4">{l s='Please check your order before payment' d='Shop.Theme.Checkout'}</p>
 
   <div class="order__summary__addresses mb-4">
     <h5 class="mb-3">
diff --git a/templates/checkout/order-confirmation.tpl b/templates/checkout/order-confirmation.tpl
index 5f44d275a..8aab47a25 100644
--- a/templates/checkout/order-confirmation.tpl
+++ b/templates/checkout/order-confirmation.tpl
@@ -10,7 +10,7 @@
 
   {block name='order_confirmation_header'}
     <div class="alert alert-success" role="alert">
-      <h4 class="alert-heading">{l s='Your order is confirmed' d='Shop.Theme.Checkout'}</h4>
+      <h1 class="fourth-title alert-heading">{l s='Your order is confirmed' d='Shop.Theme.Checkout'}</h1>
       <p class="mb-0">
         {l s='An email has been sent to your mail address %email%.' d='Shop.Theme.Checkout' sprintf=['%email%' => $order_customer.email]}
       </p>
diff --git a/templates/components/account-menu.tpl b/templates/components/account-menu.tpl
index 04bcbded3..eaea385c8 100644
--- a/templates/components/account-menu.tpl
+++ b/templates/components/account-menu.tpl
@@ -6,7 +6,7 @@
 
 {block name='account_menu'}
   <div class="{$componentName} d-none d-md-flex">
-    <p class="{$componentName}__title mb-4 h4">{l s='My Account' d='Shop.Theme.Customeraccount'}</p>
+    <p class="{$componentName}__title mb-4 fourth-title">{l s='My Account' d='Shop.Theme.Customeraccount'}</p>
     <a class="{$componentName}__line{if $urls.current_url === $urls.pages.identity} active{/if}" id="identity__link" href="{$urls.pages.identity}">
       <span class="link-item">
       <i class="material-icons" aria-hidden="true">&#xE853;</i>
diff --git a/templates/customer/_partials/account-transformation-form.tpl b/templates/customer/_partials/account-transformation-form.tpl
index 223c179aa..170278e7c 100644
--- a/templates/customer/_partials/account-transformation-form.tpl
+++ b/templates/customer/_partials/account-transformation-form.tpl
@@ -3,7 +3,7 @@
  * file that was distributed with this source code.
  *}
  {block name='account_transformation_form'}
-  <h4>{l s='Save time on your next order, sign up now' d='Shop.Theme.Checkout'}</h4>
+  <p class="fourth-title">{l s='Save time on your next order, sign up now' d='Shop.Theme.Checkout'}</p>
   <ul>
     <li> - {l s='Personalized and secure access' d='Shop.Theme.Customeraccount'}</li>
     <li> - {l s='Fast and easy checkout' d='Shop.Theme.Customeraccount'}</li>
diff --git a/templates/customer/_partials/block-address.tpl b/templates/customer/_partials/block-address.tpl
index 1ee05f991..eb1035875 100644
--- a/templates/customer/_partials/block-address.tpl
+++ b/templates/customer/_partials/block-address.tpl
@@ -5,7 +5,7 @@
 {block name='address_block_item'}
   <article id="address-{$address.id}" class="address card" data-id-address="{$address.id}">
     <div class="card-body">
-      <h4 class="address__alias card-title">{$address.alias}</h4>
+      <p class="address__alias fourth-title card-title">{$address.alias}</p>
       <address class="address__content">{$address.formatted nofilter}</address>
       {* Display the extra field values added in an address from using hook 'additionalCustomerAddressFields' *}
       {hook h='displayAdditionalCustomerAddressFields' address=$address}
diff --git a/templates/customer/order-detail.tpl b/templates/customer/order-detail.tpl
index 1db339dd5..c80ce9d17 100644
--- a/templates/customer/order-detail.tpl
+++ b/templates/customer/order-detail.tpl
@@ -100,7 +100,7 @@
         <div class="col-sm-6 mb-4">
           <article id="delivery-address" class="address card">
             <div class="card-body">
-              <h4 class="address__alias card-title">
+              <h4 class="address__alias fourth-title card-title">
                 {l s='Delivery address: %alias%' d='Shop.Theme.Checkout' sprintf=['%alias%' => $order.addresses.delivery.alias]}
               </h4>
               <address class="address__content">{$order.addresses.delivery.formatted nofilter}</address>
@@ -112,7 +112,7 @@
       <div class="col-sm-6">
         <article id="invoice-address" class="address card">
           <div class="card-body">
-            <h4 class="address__alias card-title">
+            <h4 class="address__alias fourth-title card-title">
               {l s='Invoice address: %alias%' d='Shop.Theme.Checkout' sprintf=['%alias%' => $order.addresses.invoice.alias]}
             </h4>
             <address class="address__content">{$order.addresses.invoice.formatted nofilter}</address>
diff --git a/templates/errors/404.tpl b/templates/errors/404.tpl
index f40044cd7..10b1e1f8f 100644
--- a/templates/errors/404.tpl
+++ b/templates/errors/404.tpl
@@ -11,13 +11,13 @@
 {block name='page_header_container'}
   {block name='page_title'}
     <div class="page-header mb-2">
-      <h1 class="display-1">{l s='404' d='Shop.Theme.Catalog'}</h1>
+      <p class="display-1">{l s='404' d='Shop.Theme.Catalog'}</p>
     </div>
   {/block}
 {/block}
 
 {capture assign="errorContent"}
-  <h4>{$page.title}</h4>
+  <h1 class="fourth-title">{$page.title}</h1>
   <p>
     {l
       s='If this is a recurring problem, please [1]contact us[/1]'
diff --git a/templates/errors/410.tpl b/templates/errors/410.tpl
index d554e9bad..ee512dfbf 100644
--- a/templates/errors/410.tpl
+++ b/templates/errors/410.tpl
@@ -17,7 +17,7 @@
 {/block}
 
 {capture assign="errorContent"}
-  <h4>{$page.title}</h4>
+  <h1 class="fourth-title">{$page.title}</h1>
   <p>
     {l
       s='If this is a recurring problem, please [1]contact us[/1]'
diff --git a/templates/errors/not-found.tpl b/templates/errors/not-found.tpl
index aeac328d9..3ccb2e7e1 100644
--- a/templates/errors/not-found.tpl
+++ b/templates/errors/not-found.tpl
@@ -8,7 +8,7 @@
       {if isset($errorContent)}
           {$errorContent nofilter}
       {else}
-        <h4>{l s='The page you are looking for is no longer available' d='Shop.Theme.Catalog'}</h4>
+        <h1 class="fourth-title">{l s='The page you are looking for is no longer available' d='Shop.Theme.Catalog'}</h1>
         <p>{l s='It can not be reached anymore. Can we still attract you into our shop?' d='Shop.Theme.Catalog'}</p>
         <a class="btn btn-outline-primary btn-with-icon mt-3" href="{$urls.pages.index}">
           {l s='Go shopping' d='Shop.Theme.Catalog'}