Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show which fixers were actually used #127

Open
techtonik opened this issue Oct 17, 2015 · 5 comments
Open

Show which fixers were actually used #127

techtonik opened this issue Oct 17, 2015 · 5 comments

Comments

@techtonik
Copy link
Contributor

Current verbose output is not really useful.

> python -m libmodernize upload.py --no-diffs -vvv
WARNING: Not writing files and not printing diffs; that's not very useful.
RefactoringTool: Adding transformation: apply
RefactoringTool: Adding transformation: except
RefactoringTool: Adding transformation: exec
RefactoringTool: Adding transformation: execfile
RefactoringTool: Adding transformation: exitfunc
RefactoringTool: Adding transformation: funcattrs
RefactoringTool: Adding transformation: has_key
RefactoringTool: Skipping optional fixer: idioms
RefactoringTool: Adding transformation: long
RefactoringTool: Adding transformation: methodattrs
RefactoringTool: Adding transformation: ne
RefactoringTool: Adding transformation: numliterals
RefactoringTool: Adding transformation: operator
RefactoringTool: Adding transformation: paren
RefactoringTool: Adding transformation: reduce
RefactoringTool: Adding transformation: repr
RefactoringTool: Skipping optional fixer: set_literal
RefactoringTool: Adding transformation: standarderror
RefactoringTool: Adding transformation: sys_exc
RefactoringTool: Adding transformation: throw
RefactoringTool: Adding transformation: tuple_params
RefactoringTool: Adding transformation: types
RefactoringTool: Skipping optional fixer: ws_comma
RefactoringTool: Adding transformation: xreadlines
RefactoringTool: Adding transformation: basestring
RefactoringTool: Adding transformation: dict_six
RefactoringTool: Adding transformation: file
RefactoringTool: Adding transformation: filter
RefactoringTool: Adding transformation: import
RefactoringTool: Adding transformation: imports_six
RefactoringTool: Adding transformation: input_six
RefactoringTool: Adding transformation: int_long_tuple
RefactoringTool: Adding transformation: map
RefactoringTool: Adding transformation: metaclass
RefactoringTool: Adding transformation: next
RefactoringTool: Adding transformation: print
RefactoringTool: Adding transformation: raise
RefactoringTool: Adding transformation: raise_six
RefactoringTool: Adding transformation: unicode_type
RefactoringTool: Adding transformation: xrange_six
RefactoringTool: Adding transformation: zip
RefactoringTool: Refactoring upload.py
RefactoringTool: Refactored upload.py
RefactoringTool: Not writing changes to upload.py
RefactoringTool: Files that need to be modified:
RefactoringTool: upload.py

What I want to see is what fixers were actually used for upload.py

@takluyver
Copy link
Contributor

I suspect that's all inside 2to3, so modernize can't easily change it.

@techtonik
Copy link
Contributor Author

Find a replacement to 2to3 that has better documentation and support? http://www.astroid.org/

@takluyver
Copy link
Contributor

Even if that has the capabilities we need, I don't think any of us has the time to completely rebuild python-modernize on top of something other than 2to3. For better or for worse, modernize is very tightly tied to 2to3.

Perhaps the easiest way to address it would be to take a copy of 2to3 from CPython and either bundle it into p-m, or release it as a standalone package. But let's not do that before 0.5, at any rate.

@techtonik
Copy link
Contributor Author

Ok.

@daira
Copy link
Contributor

daira commented Oct 18, 2015

We could wrap all of the fixers we add, including the ones from lib2to3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants