Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad relative imports are introduced #143

Open
pavlix opened this issue Oct 3, 2016 · 1 comment
Open

bad relative imports are introduced #143

pavlix opened this issue Oct 3, 2016 · 1 comment

Comments

@pavlix
Copy link

pavlix commented Oct 3, 2016

Modernize introduces bad syntax when dealing with imports from local packages.

Original code:

import ssl.SSLCommon

Modernized code containing syntax error:

from . import ssl.SSLCommon

Probably desired code:

from .ssl import SSLCommon as ssl_SSLCommon
@ncoghlan
Copy link

ncoghlan commented Aug 7, 2019

The local translation that will keep name resolution consistent:

from .ssl import SSLCommon # Ensure import
from . import ssl # Bind top level name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants