Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong handling of multiple unicode literals when --six-unicode is used #26

Open
daira opened this issue Aug 13, 2014 · 1 comment
Open

wrong handling of multiple unicode literals when --six-unicode is used #26

daira opened this issue Aug 13, 2014 · 1 comment
Assignees
@daira
Labels
bug has test strings wrong output
Milestone
Release 1.0

Comments

@daira
Copy link
Contributor

daira commented Aug 13, 2014

If one has:

    foo(u'.........'
        u'.........')

it gets converted to:

    foo(six.u('........')
        six.u('........'))

that obviously does not work, better would be:

    foo(six.u('.........'
              '.........'))

(moved from mitsuhiko/python-modernize#9 opened by @ThomasWaldmann)
@daira daira added the bug label Aug 13, 2014
@daira daira mentioned this issue Aug 13, 2014
Closed
daira added a commit that referenced this issue Aug 28, 2014
@daira
Test for #26 (wrong handling of multiple unicode literals); also incl…
d26e035 
…udes the test for #19. refs #19, #26

Signed-off-by: Daira Hopwood <[email protected]>
@daira daira added the has test label Aug 28, 2014
@daira daira added this to the Release 0.5 milestone Sep 27, 2014
@daira daira added the strings label Sep 29, 2014
@daira daira self-assigned this Jan 18, 2015
daira added a commit that referenced this issue May 27, 2015
@daira
Test for #26 (wrong handling of multiple unicode literals); also incl…
9ade36c 
…udes the test for #19. refs #19, #26

Signed-off-by: Daira Hopwood <[email protected]>
daira added a commit that referenced this issue May 27, 2015
@daira
Test for #26 (wrong handling of multiple unicode literals); also incl…
d0d6397 
…udes the test for #19. refs #19, #26

Signed-off-by: Daira Hopwood <[email protected]>
@daira
Copy link
Contributor Author

daira commented May 27, 2015

The test looks correct now (i.e. it fails for the right reason).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daira daira

Labels
bug has test strings wrong output
Projects
None yet
Milestone
Release 1.0
Development

No branches or pull requests
1 participant
@daira