From a0cc20eaba44292d6ad607109b32c541ff564933 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 25 Dec 2017 08:48:33 +0100 Subject: [PATCH] src: remove unused GetHostByNameWrap MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was a wrapper for `ares_gethostbyname()` that I'm unsure about if it was ever exposed at the binding layer, let alone the public API. PR-URL: https://github.com/nodejs/node/pull/17860 Reviewed-By: Colin Ihrig Reviewed-By: Jon Moss Reviewed-By: Tobias Nießen Reviewed-By: James M Snell Reviewed-By: Gibson Fahnestock --- src/cares_wrap.cc | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index 80335f2bea6cf0..b9ab1b215e0482 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -1772,33 +1772,6 @@ class GetHostByAddrWrap: public QueryWrap { }; -class GetHostByNameWrap: public QueryWrap { - public: - explicit GetHostByNameWrap(ChannelWrap* channel, Local req_wrap_obj) - : QueryWrap(channel, req_wrap_obj) { - } - - int Send(const char* name, int family) override { - ares_gethostbyname(channel_->cares_channel(), - name, - family, - Callback, - static_cast(static_cast(this))); - return 0; - } - - protected: - void Parse(struct hostent* host) override { - HandleScope scope(env()->isolate()); - - Local addresses = HostentToAddresses(env(), host); - Local family = Integer::New(env()->isolate(), host->h_addrtype); - - this->CallOnComplete(addresses, family); - } -}; - - template static void Query(const FunctionCallbackInfo& args) { Environment* env = Environment::GetCurrent(args);