Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the height and the layout issues that comes with changing the height of the subscription section #69

Closed
arsahindev opened this issue Aug 26, 2021 · 2 comments · Fixed by #84
Closed

Fix the height and the layout issues that comes with changing the height of the subscription section #69

arsahindev opened this issue Aug 26, 2021 · 2 comments · Fixed by #84
Assignees
@mimisha25 @arsahindev
Labels
bug Something isn't working
Milestone
Capstone Launch

Comments

@arsahindev
Copy link
Collaborator

Height should be calc(100vh - 120px). Whenever we change it to that height layout breaks. This need to be fixed in order to see the footer.
@Shrreya Shrreya added the bug Something isn't working label Aug 30, 2021
@Shrreya Shrreya added this to the Capstone Launch milestone Aug 30, 2021
@mimisha25
Copy link
Collaborator

Height should be calc(100vh - 120px). Whenever we change it to that height layout breaks. This need to be fixed in order to see the footer.

Done.

p.s. Would it be easier if add directly footer and see in the Homepage page with NavBar & Footer together?

@arsahindev arsahindev mentioned this issue Aug 31, 2021
Merged
@arsahindev arsahindev linked a pull request Aug 31, 2021 that will close this issue
Fix layout issues of Subscription section #84
Merged
@arsahindev arsahindev reopened this Sep 1, 2021
@arsahindev arsahindev self-assigned this Sep 1, 2021
@arsahindev
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mimisha25 mimisha25

@arsahindev arsahindev

Labels
bug Something isn't working
Projects
None yet
Milestone
Capstone Launch
Development

Successfully merging a pull request may close this issue.

Fix layout issues of Subscription section ReCoded-Org/capstone-turkey-love-thy-neighbour
3 participants
@Shrreya @mimisha25 @arsahindev