Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow <Subscriber> to render out of context? #6

Closed
mjackson opened this issue Oct 1, 2016 · 2 comments
Closed

Allow <Subscriber> to render out of context? #6

mjackson opened this issue Oct 1, 2016 · 2 comments

Comments

@mjackson
Copy link
Member

mjackson commented Oct 1, 2016

I'm opening this issue to discuss the change made in 57de4ff. I assume it was made so we can render <Link>s in the router outside of the context of a <Router>, right @ryanflorence?
mjackson referenced this issue Oct 1, 2016
@ryanflorence
allow Subscriber render out of context as a noop
57de4ff 
need to talk to @mjackson about tradeoffs here, I’m undecided, but to
avoid breaking Router, we need this for now, then we can decide to keep
it this way or not
@ryanflorence
Copy link
Member

yeah, maybe the commit message wasn't clear.
On Sat, Oct 1, 2016 at 9:23 AM Michael Jackson [email protected]
wrote:

I'm opening this issue to discuss the change made in 57de4ff
57de4ff.
I assume it was made so we can render s in the router outside of
the context of a , right @ryanflorence
https://github.com/ryanflorence?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAGHaGLB0_ys799ns-Sx4Oty5fHRz5O2ks5qvokAgaJpZM4KLy1m
.

@mjackson
Copy link
Member Author

mjackson commented Oct 1, 2016

No, the commit message was great :) Just wanted to track discussion here.

@landabaso landabaso mentioned this issue Feb 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjackson @ryanflorence