Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test test_tevkori_filter_content_images() failing against WP nightlies #251

Closed
joemcgill opened this issue Nov 16, 2015 · 2 comments
Closed

Test test_tevkori_filter_content_images() failing against WP nightlies #251

joemcgill opened this issue Nov 16, 2015 · 2 comments
Assignees
@joemcgill
Labels
Task

Comments

@joemcgill
Copy link
Member

Our unit test method, RICG_Responsive_Images_Tests::test_tevkori_filter_content_images is failing against Trunk because the fix hasn't been merged into core yet. Once the fix has been applied to core, this should pass as expected.

I'm going to leave this ticket open as a reminder until we've confirmed that all the test are passing.

See: https://core.trac.wordpress.org/ticket/34678
@joemcgill joemcgill added the Task label Nov 16, 2015
@joemcgill joemcgill self-assigned this Nov 16, 2015
@joemcgill
Copy link
Member Author

The changes to core have been made that should fix this issue.
See: https://core.trac.wordpress.org/changeset/35678

Once we've confirmed that all tests pass in the nightlies tomorrow, this can be closed.

@jaspermdegroot
Copy link
Member

Confirmed: https://travis-ci.org/ResponsiveImagesCG/wp-tevko-responsive-images/builds/92426311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joemcgill joemcgill

Labels
Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joemcgill @jaspermdegroot