Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accuracy vs Cost #4

Open
AziziShekoofeh opened this issue Feb 5, 2017 · 6 comments
Open

Accuracy vs Cost #4

AziziShekoofeh opened this issue Feb 5, 2017 · 6 comments

Comments

@AziziShekoofeh
Copy link

Hi,
Thanks for the nice example. I have a question about your check_test() function. When you're running the session and generating the output, it's [model.cost, model.accuracy] but after append and tuple you have [accuracy, cost]. I'm afraid to say that it's a swap between accuracy and cost. Even, when I ran it on another time-series dataset, it generates the accuracy of greater than 1, which is definitely incorrect.

Thanks,
Shekoofeh

@ghost
Copy link

ghost commented Mar 13, 2017

Hi,
If one flips the cost and acc to cost,acc = [np.mean(x) for x in zip(*perfs)] in the check_test() it looks like the accuracy drops down to roughly 30%. I have tested it on the two_patterns example. Is there any way to tweak the LSTM to increase the accuracy?

@AziziShekoofeh
Copy link
Author

@JosefHook You are right. It seems it's the bug in the code and the reported 80-90% accuracy is not correct. I think the only way is to retrain and research for the correct hyperparameters.

@hackerwei
Copy link

@JosefHook @JosefHook cost,acc = [np.mean(x) for x in zip(*perfs)] is the right code?

@onesmileapp
Copy link

Hi!
I feel very strange,I couldn't find the check_test() function in the tsc_model.py. if you know, could you tell me where I can find the check_test() function. Thanks

@AziziShekoofeh
Copy link
Author

Hi @onesmileapp I couldn't find it either. Maybe after the recent commits for the version compatibility, it has been changed to something else.

If you check my fork from this directory it's showing this function in line 83, tsc_main.py .

@onesmileapp
Copy link

@AziziShekoofeh yes, I have found it . thank you~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants