Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOV endpoints #2

Open
hoopty opened this issue Dec 12, 2017 · 5 comments
Open

GOV endpoints #2

hoopty opened this issue Dec 12, 2017 · 5 comments

Comments

@hoopty
Copy link

hoopty commented Dec 12, 2017

It would be ideal if endpoints could be overloaded for alternate Azure environments like Gov. I believe just the TLD changes to .us (instead of .com), but need to validate that. I'll try to work on a PR, but wanted to mention her as well.

@asheniam
Copy link
Contributor

It's not just a change from .com to .us. You need to change the endpoints for both AAD and ARM. The below file has a mapping of these endpoints for each of the different Azure clouds.
https://github.com/projectkudu/ARMClient/blob/master/ARMClient.Authentication/Constants.cs

I'd recommend exposing a new environment property under credentials section in the yaml which maps to Public, China, Germany, and USGov. Internally within the exporter, the code can look up the appropriate endpoint.

@brian-brazil
Copy link
Member

Do Microsoft have a library for this?

@asheniam
Copy link
Contributor

I don't know if there is an official library for this but in Azure PowerShell, there is a cmdlet called Get-AzureRmEnvironment which returns back the environment settings for each of the clouds. Looking at the PowerShell code, it maps back to this file -- which is probably more official than the link I posted above.

https://github.com/Azure/azure-powershell/blob/8bd4c84a1b51b86ffc2d8977d5dcc438df480afa/src/Common/Commands.Common.Authentication.Abstractions/AzureEnvironmentConstants.cs

@brian-brazil
Copy link
Member

That's CSharp which won't help us much. Is there a java one somewhere?

@asheniam
Copy link
Contributor

I checked the Azure SDK for Java but I didn't see anything. I would check with the folks here.
https://github.com/Azure/azure-libraries-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants