Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Does Not Seem Correct on Japanese Characters #32

Closed
gabehxd opened this issue Jan 22, 2020 · 3 comments
Closed

Output Does Not Seem Correct on Japanese Characters #32

gabehxd opened this issue Jan 22, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@gabehxd
Copy link

gabehxd commented Jan 22, 2020

image
image
The outputted string is also not a valid filename which may or may not be in the intended scope?
Separator is also not working as intended.

@RubenMateus
Copy link
Owner

Hi there @SunTheCourier. thank you for using this package. there are still some cases I maybe didn't' have support.
The separator might be a valid point, maybe i should apply the separator after normalize it.
are you using sluggy or sluggy unidecode?

@RubenMateus RubenMateus pinned this issue Jan 25, 2020
@RubenMateus RubenMateus added the bug Something isn't working label Jan 25, 2020
@RubenMateus RubenMateus self-assigned this Jan 25, 2020
@gabehxd
Copy link
Author

gabehxd commented Jan 26, 2020

I installed Sluggy Unideocde

@RubenMateus
Copy link
Owner

RubenMateus commented May 26, 2020

hi @SunTheCourier, can you check with the latest version?
I would recommend using SluggyUnidecode and use the overload:
{filename}.ToSlug("_");

Or just use the same overload you were using, should be correct now.
If it's still not correct, can you please provide a few test cases in a Pull request?
So I can check them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants