Resizing Cache to 0 in tests 🚨

Author: SAHU-01

host/contracts/integrity_test.go

@@ -86,10 +86,8 @@ func TestCheckIntegrity(t *testing.T) {
 	}
 	defer s.Close()
 
-	// Disable cache for this test
-	if err := s.ResizeCache(0); err != nil {
-		t.Fatal(err)
-	}
+	// Resize cache to 0 sectors
+	s.ResizeCache(0)
 
 	result := make(chan error, 1)
 	if _, err := s.AddVolume(filepath.Join(dir, "data.dat"), 10, result); err != nil {

host/storage/storage.go

@@ -192,7 +192,7 @@ func (vm *VolumeManager) loadVolumes() error {
 			vm.a.Register(alerts.Alert{
 				ID:       frand.Entropy256(),
 				Severity: alerts.SeverityError,
-				Message:  fmt.Sprintf("Failed to open volume %q", vol.LocalPath),
+				Message:  "Failed to open volume",
 				Data: map[string]any{
 					"volume": vol.LocalPath,
 					"error":  err.Error(),
@@ -633,6 +633,7 @@ func (vm *VolumeManager) AddVolume(localPath string, maxSectors uint64, result c
 			log.Error("failed to initialize volume", zap.Error(err))
 			alert.Message = "Failed to initialize volume"
 			alert.Severity = alerts.SeverityError
+			alert.Data["error"] = err.Error()
 		} else {
 			alert.Message = "Volume initialized"
 			alert.Severity = alerts.SeverityInfo
@@ -977,9 +978,9 @@ func (vm *VolumeManager) PruneSectors() (int, error) {
 }
 
 // ResizeCache resizes the cache to the given size.
-func (vm *VolumeManager) ResizeCache(size int) error {
+func (vm *VolumeManager) ResizeCache(size int) {
+	// Resize the underlying cache data structure
 	vm.cache.Resize(size)
-	return nil
 }
 
 // NewVolumeManager creates a new VolumeManager.

host/storage/storage_test.go

@@ -327,6 +327,9 @@ func TestRemoveCorrupt(t *testing.T) {
 	}
 	defer vm.Close()
 
+	// Resize cache to 0 sectors
+	vm.ResizeCache(0)
+
 	result := make(chan error, 1)
 	volumePath := filepath.Join(t.TempDir(), "hostdata.dat")
 	volume, err := vm.AddVolume(volumePath, expectedSectors, result)

rhp/v3/rpc_test.go

@@ -152,11 +152,8 @@ func TestStoreSector(t *testing.T) {
 	defer renter.Close()
 	defer host.Close()
 
-	// Get storage manager and disable cache
-	s := host.Storage()
-	if err := s.ResizeCache(0); err != nil {
-		t.Fatal(err)
-	}
+	// Resize cache to 0 sectors
+	host.Storage().ResizeCache(0)
 
 	session, err := renter.NewRHP3Session(context.Background(), host.RHPv3Addr(), host.PublicKey())
 	if err != nil {