Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The del_threshold is hardcoded in step function type custom #112

Closed
SarahAlidoost opened this issue Aug 22, 2024 · 2 comments
Closed

The del_threshold is hardcoded in step function type custom #112

SarahAlidoost opened this issue Aug 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@SarahAlidoost
Copy link
Member

As can be seen here, first threshold is calculated and then it is used in link_deletion. Therefore, users can no longer modify the threshold or switch to a different del_method, such as probability.

@vmgaribay
Copy link

It is a custom step, so users shouldn't be using it casually; that is, I believe, the purpose of having different steps such as "default". Creating a new method for "equalize" or an assert for the method used in the step or an if case is a good idea, but it is also a complete non-priority.

@vmgaribay
Copy link

vmgaribay commented Sep 4, 2024

I have renamed "custom" as "ptm" and added an acceptable threshold value "balance" which triggers a conditional case in the "ptm" step. It is part of the sensitivity analysis pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants