From cd887bb66caf3444a53b1e4c5cb2a3dc853b97fa Mon Sep 17 00:00:00 2001 From: Sneha Belkhale Date: Fri, 12 Apr 2019 23:51:50 +0800 Subject: [PATCH 1/3] fixing rbmax / rbmin calculation --- examples/webgl_materials_envmaps_parallax.html | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/webgl_materials_envmaps_parallax.html b/examples/webgl_materials_envmaps_parallax.html index 52f3061db64a7b..d7196008b0b7ac 100644 --- a/examples/webgl_materials_envmaps_parallax.html +++ b/examples/webgl_materials_envmaps_parallax.html @@ -79,8 +79,8 @@ vec3 parallaxCorrectNormal( vec3 v, vec3 cubeSize, vec3 cubePos ) { vec3 nDir = normalize( v ); - vec3 rbmax = ( .5 * ( cubeSize - cubePos ) - vWorldPosition ) / nDir; - vec3 rbmin = ( - .5 * ( cubeSize - cubePos ) - vWorldPosition ) / nDir; + vec3 rbmax = ( .5 * cubeSize + cubePos - vWorldPosition ) / nDir; + vec3 rbmin = ( -.5 * cubeSize + cubePos - vWorldPosition ) / nDir; vec3 rbminmax; rbminmax.x = ( nDir.x > 0. ) ? rbmax.x : rbmin.x; @@ -356,7 +356,8 @@ boxProjectedMat.onBeforeCompile = function ( shader ) { - shader.uniforms.cubeMapSize = { value: new THREE.Vector3( 200, 100, 100 ) }; + //these parameters are wrt the cubeCamera texture + shader.uniforms.cubeMapSize = { value: new THREE.Vector3( 200, 200, 100 ) }; shader.uniforms.cubeMapPos = { value: new THREE.Vector3( 0, - 50, 0 ) }; shader.uniforms.flipEnvMap.value = true; From b5d6025534f4bedeb008a489ae6fca2c3046044a Mon Sep 17 00:00:00 2001 From: Sneha Belkhale Date: Mon, 15 Apr 2019 01:03:09 +0800 Subject: [PATCH 2/3] fixing comment --- examples/webgl_materials_envmaps_parallax.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/webgl_materials_envmaps_parallax.html b/examples/webgl_materials_envmaps_parallax.html index d7196008b0b7ac..a57c6a453ec2d9 100644 --- a/examples/webgl_materials_envmaps_parallax.html +++ b/examples/webgl_materials_envmaps_parallax.html @@ -356,7 +356,7 @@ boxProjectedMat.onBeforeCompile = function ( shader ) { - //these parameters are wrt the cubeCamera texture + //these parameters are with respect to the cubeCamera texture shader.uniforms.cubeMapSize = { value: new THREE.Vector3( 200, 200, 100 ) }; shader.uniforms.cubeMapPos = { value: new THREE.Vector3( 0, - 50, 0 ) }; shader.uniforms.flipEnvMap.value = true; From c4ff20ef9578653ab5b43a9efb160246705ac548 Mon Sep 17 00:00:00 2001 From: Sneha Belkhale Date: Mon, 15 Apr 2019 01:06:55 +0800 Subject: [PATCH 3/3] fixing comment again --- examples/webgl_materials_envmaps_parallax.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/webgl_materials_envmaps_parallax.html b/examples/webgl_materials_envmaps_parallax.html index a57c6a453ec2d9..1a4906dc58e278 100644 --- a/examples/webgl_materials_envmaps_parallax.html +++ b/examples/webgl_materials_envmaps_parallax.html @@ -356,7 +356,7 @@ boxProjectedMat.onBeforeCompile = function ( shader ) { - //these parameters are with respect to the cubeCamera texture + //these parameters are for the cubeCamera texture shader.uniforms.cubeMapSize = { value: new THREE.Vector3( 200, 200, 100 ) }; shader.uniforms.cubeMapPos = { value: new THREE.Vector3( 0, - 50, 0 ) }; shader.uniforms.flipEnvMap.value = true;