Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Change Global Action IDs to match those found in BRSW #145

Open
SalieriC opened this issue Mar 14, 2024 · 1 comment
Open
Assignees

Comments

@SalieriC
Copy link
Owner

BRSW added multiple Global Actions also found in SWIM. Those live along side each other not, applying their roll modifiers multiple times. The requirements for modules to overwrite those in BRSW are there but the IDs need to match. So all that is left to do is change the IDs in Swim to match those in BRSW.
It is preferable to keep the Global Actions in SWIM to overwrite those in BRSW instead of using theirs to ensure compatibility in case of changes.

@SalieriC SalieriC self-assigned this Mar 14, 2024
@SalieriC
Copy link
Owner Author

There currently is a problem with that:
BRSW uses three actions to cover deflection while SWIM uses just two. That's why SWIM cannot overwrite an action. There are several things that could be done:

  • Ask BRSW to convert to two actions for deflection.
  • Ask BRSW to introduce an API function to delete/disable actions (not preferred).
  • Revert back to three actions for deflection in SWIM (not preferred as it takes more lines of code to add redundancy and is harder to maintain).
  • Some kind of trickery with an empty action just to be able to overwrite the one in BRSW (also not preferred).

Currently waiting for a response from BRSW. TL;DR: SWIM can't overwrite an action in BRSW that SWIM doesn't have itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant