improvements for getFileSize

kssenii · kssenii · commit 5dd1bb2fd863 · 2022-06-20T15:22:56.000+02:00
diff --git a/src/Client/ClientBase.cpp b/src/Client/ClientBase.cpp
@@ -1125,7 +1125,7 @@ void ClientBase::sendData(Block & sample, const ColumnsDescription & columns_des
     if (need_render_progress && have_data_in_stdin)
     {
         /// Set total_bytes_to_read for current fd.
-        FileProgress file_progress(0, std_in.size());
+        FileProgress file_progress(0, std_in.getFileSize());
         progress_indication.updateProgress(Progress(file_progress));
 
         /// Set callback to be called on file progress.
diff --git a/src/Common/filesystemHelpers.cpp b/src/Common/filesystemHelpers.cpp
@@ -17,6 +17,7 @@
 #include <IO/ReadBufferFromFile.h>
 #include <IO/Operators.h>
 #include <IO/WriteBufferFromString.h>
+#include <Common/Exception.h>
 
 namespace fs = std::filesystem;
 
@@ -29,6 +30,7 @@ namespace ErrorCodes
     extern const int SYSTEM_ERROR;
     extern const int NOT_IMPLEMENTED;
     extern const int CANNOT_STAT;
+    extern const int CANNOT_FSTAT;
     extern const int CANNOT_STATVFS;
     extern const int PATH_ACCESS_DENIED;
     extern const int CANNOT_CREATE_FILE;
@@ -215,6 +217,20 @@ bool fileOrSymlinkPathStartsWith(const String & path, const String & prefix_path
     return fileOrSymlinkPathStartsWith(filesystem_path, filesystem_prefix_path);
 }
 
+size_t getSizeFromFileDescriptor(int fd, const String & file_name)
+{
+    struct stat buf;
+    int res = fstat(fd, &buf);
+    if (-1 == res)
+    {
+        throwFromErrnoWithPath(
+            "Cannot execute fstat" + (file_name.empty() ? "" : " file: " + file_name),
+            file_name,
+            ErrorCodes::CANNOT_FSTAT);
+    }
+    return buf.st_size;
+}
+
 }
 
 
diff --git a/src/Common/filesystemHelpers.h b/src/Common/filesystemHelpers.h
@@ -64,6 +64,8 @@ bool pathStartsWith(const String & path, const String & prefix_path);
 /// (Path is made absolute and normalized.)
 bool fileOrSymlinkPathStartsWith(const String & path, const String & prefix_path);
 
+size_t getSizeFromFileDescriptor(int fd, const String & file_name = "");
+
 }
 
 namespace FS
diff --git a/src/Disks/IO/AsynchronousReadIndirectBufferFromRemoteFS.cpp b/src/Disks/IO/AsynchronousReadIndirectBufferFromRemoteFS.cpp
@@ -67,7 +67,7 @@ String AsynchronousReadIndirectBufferFromRemoteFS::getInfoForLog()
     return impl->getInfoForLog();
 }
 
-std::optional<size_t> AsynchronousReadIndirectBufferFromRemoteFS::getFileSize()
+size_t AsynchronousReadIndirectBufferFromRemoteFS::getFileSize()
 {
     return impl->getFileSize();
 }
diff --git a/src/Disks/IO/AsynchronousReadIndirectBufferFromRemoteFS.h b/src/Disks/IO/AsynchronousReadIndirectBufferFromRemoteFS.h
@@ -27,7 +27,7 @@ struct ReadSettings;
 *
 * We pass either `memory` or `prefetch_buffer` through all this chain and return it back.
 */
-class AsynchronousReadIndirectBufferFromRemoteFS : public ReadBufferFromFileBase, public WithFileSize
+class AsynchronousReadIndirectBufferFromRemoteFS : public ReadBufferFromFileBase
 {
 public:
     explicit AsynchronousReadIndirectBufferFromRemoteFS(
@@ -51,7 +51,7 @@ class AsynchronousReadIndirectBufferFromRemoteFS : public ReadBufferFromFileBase
 
     String getInfoForLog() override;
 
-    std::optional<size_t> getFileSize() override;
+    size_t getFileSize() override;
 
 private:
     bool nextImpl() override;
diff --git a/src/Disks/IO/CachedReadBufferFromRemoteFS.cpp b/src/Disks/IO/CachedReadBufferFromRemoteFS.cpp
@@ -129,7 +129,7 @@ SeekableReadBufferPtr CachedReadBufferFromRemoteFS::getCacheReadBuffer(size_t of
 
     auto buf = createReadBufferFromFileBase(path, local_read_settings);
     auto * from_fd = dynamic_cast<ReadBufferFromFileDescriptor*>(buf.get());
-    if (from_fd && from_fd->size() == 0)
+    if (from_fd && from_fd->getFileSize() == 0)
         throw Exception(ErrorCodes::LOGICAL_ERROR, "Attempt to read from an empty cache file: {}", path);
 
     return buf;
@@ -371,7 +371,7 @@ SeekableReadBufferPtr CachedReadBufferFromRemoteFS::getImplementationBuffer(File
         {
 #ifndef NDEBUG
             auto * file_reader = dynamic_cast<ReadBufferFromFileDescriptor *>(read_buffer_for_file_segment.get());
-            size_t file_size = file_reader->size();
+            size_t file_size = file_reader->getFileSize();
 
             if (file_size == 0 || range.left + file_size <= file_offset_of_buffer_end)
                 throw Exception(
@@ -803,7 +803,7 @@ bool CachedReadBufferFromRemoteFS::nextImplStep()
 #ifndef NDEBUG
         if (auto * cache_file_reader = dynamic_cast<ReadBufferFromFileDescriptor *>(implementation_buffer.get()))
         {
-            auto cache_file_size = cache_file_reader->size();
+            auto cache_file_size = cache_file_reader->getFileSize();
             if (cache_file_size == 0)
                 throw Exception(
                     ErrorCodes::LOGICAL_ERROR, "Attempt to read from an empty cache file: {} (just before actual read)", cache_file_size);
@@ -917,7 +917,7 @@ bool CachedReadBufferFromRemoteFS::nextImplStep()
     {
         std::optional<size_t> cache_file_size;
         if (auto * cache_file_reader = dynamic_cast<ReadBufferFromFileDescriptor *>(implementation_buffer.get()))
-            cache_file_size = cache_file_reader->size();
+            cache_file_size = cache_file_reader->getFileSize();
 
         throw Exception(
             ErrorCodes::LOGICAL_ERROR,
diff --git a/src/Disks/IO/ReadIndirectBufferFromRemoteFS.cpp b/src/Disks/IO/ReadIndirectBufferFromRemoteFS.cpp
@@ -19,6 +19,10 @@ ReadIndirectBufferFromRemoteFS::ReadIndirectBufferFromRemoteFS(
 {
 }
 
+size_t ReadIndirectBufferFromRemoteFS::getFileSize()
+{
+    return impl->getFileSize();
+}
 
 off_t ReadIndirectBufferFromRemoteFS::getPosition()
 {
diff --git a/src/Disks/IO/ReadIndirectBufferFromRemoteFS.h b/src/Disks/IO/ReadIndirectBufferFromRemoteFS.h
@@ -30,6 +30,8 @@ class ReadIndirectBufferFromRemoteFS : public ReadBufferFromFileBase
 
     void setReadUntilEnd() override;
 
+    size_t getFileSize() override;
+
 private:
     bool nextImpl() override;
 
diff --git a/src/IO/AsynchronousReadBufferFromFileDescriptor.cpp b/src/IO/AsynchronousReadBufferFromFileDescriptor.cpp
@@ -7,6 +7,7 @@
 #include <Common/CurrentMetrics.h>
 #include <IO/AsynchronousReadBufferFromFileDescriptor.h>
 #include <IO/WriteHelpers.h>
+#include <Common/filesystemHelpers.h>
 
 
 namespace ProfileEvents
@@ -243,4 +244,9 @@ void AsynchronousReadBufferFromFileDescriptor::rewind()
     file_offset_of_buffer_end = 0;
 }
 
+size_t AsynchronousReadBufferFromFileDescriptor::getFileSize()
+{
+    return getSizeFromFileDescriptor(fd, getFileName());
+}
+
 }
diff --git a/src/IO/AsynchronousReadBufferFromFileDescriptor.h b/src/IO/AsynchronousReadBufferFromFileDescriptor.h
@@ -64,9 +64,10 @@ class AsynchronousReadBufferFromFileDescriptor : public ReadBufferFromFileBase
     /// Seek to the beginning, discarding already read data if any. Useful to reread file that changes on every read.
     void rewind();
 
+    size_t getFileSize() override;
+
 private:
     std::future<IAsynchronousReader::Result> asyncReadInto(char * data, size_t size);
 };
 
 }
-
diff --git a/src/IO/ConcatSeekableReadBuffer.h b/src/IO/ConcatSeekableReadBuffer.h
@@ -21,7 +21,7 @@ class ConcatSeekableReadBuffer : public SeekableReadBuffer, public WithFileSize
     off_t seek(off_t off, int whence) override;
     off_t getPosition() override;
 
-    std::optional<size_t> getFileSize() override { return total_size; }
+    size_t getFileSize() override { return total_size; }
 
 private:
     bool nextImpl() override;
diff --git a/src/IO/MMapReadBufferFromFileDescriptor.cpp b/src/IO/MMapReadBufferFromFileDescriptor.cpp
@@ -6,6 +6,7 @@
 #include <Common/ProfileEvents.h>
 #include <Common/formatReadable.h>
 #include <Common/Exception.h>
+#include <Common/filesystemHelpers.h>
 #include <base/getPageSize.h>
 #include <IO/WriteHelpers.h>
 #include <IO/MMapReadBufferFromFileDescriptor.h>
@@ -86,4 +87,8 @@ off_t MMapReadBufferFromFileDescriptor::seek(off_t offset, int whence)
     return new_pos;
 }
 
+size_t MMapReadBufferFromFileDescriptor::getFileSize()
+{
+    return getSizeFromFileDescriptor(getFD(), getFileName());
+}
 }
diff --git a/src/IO/MMapReadBufferFromFileDescriptor.h b/src/IO/MMapReadBufferFromFileDescriptor.h
@@ -33,9 +33,12 @@ class MMapReadBufferFromFileDescriptor : public ReadBufferFromFileBase
     void finish();
 
     off_t getPosition() override;
+
     std::string getFileName() const override;
+
     int getFD() const;
+
+    size_t getFileSize() override;
 };
 
 }
-
diff --git a/src/IO/ParallelReadBuffer.cpp b/src/IO/ParallelReadBuffer.cpp
@@ -150,7 +150,7 @@ off_t ParallelReadBuffer::seek(off_t offset, int whence)
     return offset;
 }
 
-std::optional<size_t> ParallelReadBuffer::getFileSize()
+size_t ParallelReadBuffer::getFileSize()
 {
     return reader_factory->getFileSize();
 }
diff --git a/src/IO/ParallelReadBuffer.h b/src/IO/ParallelReadBuffer.h
@@ -43,7 +43,7 @@ class ParallelReadBuffer : public SeekableReadBuffer
     ~ParallelReadBuffer() override { finishAndWait(); }
 
     off_t seek(off_t off, int whence) override;
-    std::optional<size_t> getFileSize();
+    size_t getFileSize();
     off_t getPosition() override;
 
     const ReadBufferFactory & getReadBufferFactory() const { return *reader_factory; }
diff --git a/src/IO/ReadBufferFromEmptyFile.h b/src/IO/ReadBufferFromEmptyFile.h
@@ -19,6 +19,7 @@ class ReadBufferFromEmptyFile : public ReadBufferFromFileBase
     std::string getFileName() const override { return "<empty>"; }
     off_t seek(off_t /*off*/, int /*whence*/) override { return 0; }
     off_t getPosition() override { return 0; }
+    size_t getFileSize() override { return 0; }
 };
 
 }
diff --git a/src/IO/ReadBufferFromEncryptedFile.h b/src/IO/ReadBufferFromEncryptedFile.h
@@ -30,6 +30,8 @@ class ReadBufferFromEncryptedFile : public ReadBufferFromFileBase
 
     void setReadUntilEnd() override { in->setReadUntilEnd(); }
 
+    size_t getFileSize() override { return in->getFileSize(); }
+
 private:
     bool nextImpl() override;
 
diff --git a/src/IO/ReadBufferFromFileBase.cpp b/src/IO/ReadBufferFromFileBase.cpp
@@ -3,6 +3,11 @@
 namespace DB
 {
 
+namespace ErrorCodes
+{
+    extern const int NOT_IMPLEMENTED;
+}
+
 ReadBufferFromFileBase::ReadBufferFromFileBase() : BufferWithOwnMemory<SeekableReadBuffer>(0)
 {
 }
@@ -19,4 +24,11 @@ ReadBufferFromFileBase::ReadBufferFromFileBase(
 
 ReadBufferFromFileBase::~ReadBufferFromFileBase() = default;
 
+size_t ReadBufferFromFileBase::getFileSize()
+{
+    if (file_size)
+        return *file_size;
+    throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Cannot find out file size for read buffer");
+}
+
 }
diff --git a/src/IO/ReadBufferFromFileBase.h b/src/IO/ReadBufferFromFileBase.h
@@ -20,7 +20,8 @@
 
 namespace DB
 {
-class ReadBufferFromFileBase : public BufferWithOwnMemory<SeekableReadBuffer>, public WithFileName
+
+class ReadBufferFromFileBase : public BufferWithOwnMemory<SeekableReadBuffer>, public WithFileName, public WithFileSize
 {
 public:
     ReadBufferFromFileBase();
@@ -48,6 +49,8 @@ class ReadBufferFromFileBase : public BufferWithOwnMemory<SeekableReadBuffer>, p
         clock_type = clock_type_;
     }
 
+    size_t getFileSize() override;
+
 protected:
     std::optional<size_t> file_size;
     ProfileCallback profile_callback;
diff --git a/src/IO/ReadBufferFromFileDecorator.cpp b/src/IO/ReadBufferFromFileDecorator.cpp
@@ -53,4 +53,9 @@ bool ReadBufferFromFileDecorator::nextImpl()
     return result;
 }
 
+size_t ReadBufferFromFileDecorator::getFileSize()
+{
+    return getFileSizeFromReadBuffer(*impl);
+}
+
 }
diff --git a/src/IO/ReadBufferFromFileDecorator.h b/src/IO/ReadBufferFromFileDecorator.h
@@ -27,6 +27,8 @@ class ReadBufferFromFileDecorator : public ReadBufferFromFileBase
 
     ReadBuffer & getWrappedReadBuffer() { return *impl; }
 
+    size_t getFileSize() override;
+
 protected:
     std::unique_ptr<SeekableReadBuffer> impl;
     String file_name;
diff --git a/src/IO/ReadBufferFromFileDescriptor.cpp b/src/IO/ReadBufferFromFileDescriptor.cpp
@@ -8,6 +8,7 @@
 #include <IO/ReadBufferFromFileDescriptor.h>
 #include <IO/WriteHelpers.h>
 #include <IO/Progress.h>
+#include <Common/filesystemHelpers.h>
 #include <sys/stat.h>
 
 
@@ -249,13 +250,9 @@ bool ReadBufferFromFileDescriptor::poll(size_t timeout_microseconds)
 }
 
 
-off_t ReadBufferFromFileDescriptor::size()
+size_t ReadBufferFromFileDescriptor::getFileSize()
 {
-    struct stat buf;
-    int res = fstat(fd, &buf);
-    if (-1 == res)
-        throwFromErrnoWithPath("Cannot execute fstat " + getFileName(), getFileName(), ErrorCodes::CANNOT_FSTAT);
-    return buf.st_size;
+    return getSizeFromFileDescriptor(fd, getFileName());
 }
 
 
diff --git a/src/IO/ReadBufferFromFileDescriptor.h b/src/IO/ReadBufferFromFileDescriptor.h
@@ -57,7 +57,7 @@ class ReadBufferFromFileDescriptor : public ReadBufferFromFileBase
     /// Seek to the beginning, discarding already read data if any. Useful to reread file that changes on every read.
     void rewind();
 
-    off_t size();
+    size_t getFileSize() override;
 
     void setProgressCallback(ContextPtr context);
 
diff --git a/src/IO/ReadBufferFromS3.cpp b/src/IO/ReadBufferFromS3.cpp
@@ -222,20 +222,15 @@ off_t ReadBufferFromS3::seek(off_t offset_, int whence)
     return offset;
 }
 
-std::optional<size_t> ReadBufferFromS3::getFileSize()
+size_t ReadBufferFromS3::getFileSize()
 {
     if (file_size)
-        return file_size;
+        return *file_size;
 
     auto object_size = S3::getObjectSize(client_ptr, bucket, key, version_id, false);
 
-    if (!object_size)
-    {
-        return std::nullopt;
-    }
-
     file_size = object_size;
-    return file_size;
+    return *file_size;
 }
 
 off_t ReadBufferFromS3::getPosition()
@@ -339,7 +334,7 @@ off_t ReadBufferS3Factory::seek(off_t off, [[maybe_unused]] int whence)
     return off;
 }
 
-std::optional<size_t> ReadBufferS3Factory::getFileSize()
+size_t ReadBufferS3Factory::getFileSize()
 {
     return object_size;
 }
diff --git a/src/IO/ReadBufferFromS3.h b/src/IO/ReadBufferFromS3.h
@@ -65,7 +65,7 @@ class ReadBufferFromS3 : public SeekableReadBuffer, public WithFileName, public
 
     off_t getPosition() override;
 
-    std::optional<size_t> getFileSize() override;
+    size_t getFileSize() override;
 
     void setReadUntilPosition(size_t position) override;
 
@@ -120,7 +120,7 @@ class ReadBufferS3Factory : public ParallelReadBuffer::ReadBufferFactory, public
 
     off_t seek(off_t off, [[maybe_unused]] int whence) override;
 
-    std::optional<size_t> getFileSize() override;
+    size_t getFileSize() override;
 
     String getFileName() const override { return bucket + "/" + key; }
 
diff --git a/src/IO/ReadWriteBufferFromHTTP.h b/src/IO/ReadWriteBufferFromHTTP.h
diff --git a/src/IO/WithFileSize.cpp b/src/IO/WithFileSize.cpp
diff --git a/src/IO/WithFileSize.h b/src/IO/WithFileSize.h
diff --git a/src/IO/ZstdDeflatingAppendableWriteBuffer.cpp b/src/IO/ZstdDeflatingAppendableWriteBuffer.cpp
diff --git a/src/Processors/Formats/Impl/ArrowBufferedStreams.cpp b/src/Processors/Formats/Impl/ArrowBufferedStreams.cpp
diff --git a/src/Storages/Cache/ExternalDataSourceCache.h b/src/Storages/Cache/ExternalDataSourceCache.h
diff --git a/src/Storages/HDFS/AsynchronousReadBufferFromHDFS.cpp b/src/Storages/HDFS/AsynchronousReadBufferFromHDFS.cpp
diff --git a/src/Storages/HDFS/AsynchronousReadBufferFromHDFS.h b/src/Storages/HDFS/AsynchronousReadBufferFromHDFS.h
diff --git a/src/Storages/HDFS/ReadBufferFromHDFS.cpp b/src/Storages/HDFS/ReadBufferFromHDFS.cpp
diff --git a/src/Storages/HDFS/ReadBufferFromHDFS.h b/src/Storages/HDFS/ReadBufferFromHDFS.h

Original file line number	Diff line number	Diff line change
`@@ -1125,7 +1125,7 @@ void ClientBase::sendData(Block & sample, const ColumnsDescription & columns_des`
`1125`	`1125`	`if (need_render_progress && have_data_in_stdin)`
`1126`	`1126`	`{`
`1127`	`1127`	`/// Set total_bytes_to_read for current fd.`
`1128`		`- FileProgress file_progress(0, std_in.size());`
	`1128`	`+ FileProgress file_progress(0, std_in.getFileSize());`
`1129`	`1129`	`progress_indication.updateProgress(Progress(file_progress));`
`1130`	`1130`
`1131`	`1131`	`/// Set callback to be called on file progress.`
Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,8 @@ bool pathStartsWith(const String & path, const String & prefix_path);`
`64`	`64`	`/// (Path is made absolute and normalized.)`
`65`	`65`	`bool fileOrSymlinkPathStartsWith(const String & path, const String & prefix_path);`
`66`	`66`
	`67`	`+size_t getSizeFromFileDescriptor(int fd, const String & file_name = "");`
	`68`	`+`
`67`	`69`	`}`
`68`	`70`
`69`	`71`	`namespace FS`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ String AsynchronousReadIndirectBufferFromRemoteFS::getInfoForLog()`
`67`	`67`	`return impl->getInfoForLog();`
`68`	`68`	`}`
`69`	`69`
`70`		`-std::optional<size_t> AsynchronousReadIndirectBufferFromRemoteFS::getFileSize()`
	`70`	`+size_t AsynchronousReadIndirectBufferFromRemoteFS::getFileSize()`
`71`	`71`	`{`
`72`	`72`	`return impl->getFileSize();`
`73`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ struct ReadSettings;`
`27`	`27`	`*`
`28`	`28`	* We pass either `memory` or `prefetch_buffer` through all this chain and return it back.
`29`	`29`	`*/`
`30`		`-class AsynchronousReadIndirectBufferFromRemoteFS : public ReadBufferFromFileBase, public WithFileSize`
	`30`	`+class AsynchronousReadIndirectBufferFromRemoteFS : public ReadBufferFromFileBase`
`31`	`31`	`{`
`32`	`32`	`public:`
`33`	`33`	`explicit AsynchronousReadIndirectBufferFromRemoteFS(`
`@@ -51,7 +51,7 @@ class AsynchronousReadIndirectBufferFromRemoteFS : public ReadBufferFromFileBase`
`51`	`51`
`52`	`52`	`String getInfoForLog() override;`
`53`	`53`
`54`		`- std::optional<size_t> getFileSize() override;`
	`54`	`+ size_t getFileSize() override;`
`55`	`55`
`56`	`56`	`private:`
`57`	`57`	`bool nextImpl() override;`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,10 @@ ReadIndirectBufferFromRemoteFS::ReadIndirectBufferFromRemoteFS(`
`19`	`19`	`{`
`20`	`20`	`}`
`21`	`21`
	`22`	`+size_t ReadIndirectBufferFromRemoteFS::getFileSize()`
	`23`	`+{`
	`24`	`+ return impl->getFileSize();`
	`25`	`+}`
`22`	`26`
`23`	`27`	`off_t ReadIndirectBufferFromRemoteFS::getPosition()`
`24`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`#include <Common/CurrentMetrics.h>`
`8`	`8`	`#include <IO/AsynchronousReadBufferFromFileDescriptor.h>`
`9`	`9`	`#include <IO/WriteHelpers.h>`
	`10`	`+#include <Common/filesystemHelpers.h>`
`10`	`11`
`11`	`12`
`12`	`13`	`namespace ProfileEvents`
`@@ -243,4 +244,9 @@ void AsynchronousReadBufferFromFileDescriptor::rewind()`
`243`	`244`	`file_offset_of_buffer_end = 0;`
`244`	`245`	`}`
`245`	`246`
	`247`	`+size_t AsynchronousReadBufferFromFileDescriptor::getFileSize()`
	`248`	`+{`
	`249`	`+ return getSizeFromFileDescriptor(fd, getFileName());`
	`250`	`+}`
	`251`	`+`
`246`	`252`	`}`
Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ off_t ParallelReadBuffer::seek(off_t offset, int whence)`
`150`	`150`	`return offset;`
`151`	`151`	`}`
`152`	`152`
`153`		`-std::optional<size_t> ParallelReadBuffer::getFileSize()`
	`153`	`+size_t ParallelReadBuffer::getFileSize()`
`154`	`154`	`{`
`155`	`155`	`return reader_factory->getFileSize();`
`156`	`156`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ class ReadBufferFromEmptyFile : public ReadBufferFromFileBase`
`19`	`19`	`std::string getFileName() const override { return "<empty>"; }`
`20`	`20`	`off_t seek(off_t /off/, int /whence/) override { return 0; }`
`21`	`21`	`off_t getPosition() override { return 0; }`
	`22`	`+ size_t getFileSize() override { return 0; }`
`22`	`23`	`};`
`23`	`24`
`24`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,11 @@`
`3`	`3`	`namespace DB`
`4`	`4`	`{`
`5`	`5`
	`6`	`+namespace ErrorCodes`
	`7`	`+{`
	`8`	`+ extern const int NOT_IMPLEMENTED;`
	`9`	`+}`
	`10`	`+`
`6`	`11`	`ReadBufferFromFileBase::ReadBufferFromFileBase() : BufferWithOwnMemory<SeekableReadBuffer>(0)`
`7`	`12`	`{`
`8`	`13`	`}`
`@@ -19,4 +24,11 @@ ReadBufferFromFileBase::ReadBufferFromFileBase(`
`19`	`24`
`20`	`25`	`ReadBufferFromFileBase::~ReadBufferFromFileBase() = default;`
`21`	`26`
	`27`	`+size_t ReadBufferFromFileBase::getFileSize()`
	`28`	`+{`
	`29`	`+ if (file_size)`
	`30`	`+ return *file_size;`
	`31`	`+ throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Cannot find out file size for read buffer");`
	`32`	`+}`
	`33`	`+`
`22`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,8 @@`
`20`	`20`
`21`	`21`	`namespace DB`
`22`	`22`	`{`
`23`		`-class ReadBufferFromFileBase : public BufferWithOwnMemory<SeekableReadBuffer>, public WithFileName`
	`23`	`+`
	`24`	`+class ReadBufferFromFileBase : public BufferWithOwnMemory<SeekableReadBuffer>, public WithFileName, public WithFileSize`
`24`	`25`	`{`
`25`	`26`	`public:`
`26`	`27`	`ReadBufferFromFileBase();`
`@@ -48,6 +49,8 @@ class ReadBufferFromFileBase : public BufferWithOwnMemory<SeekableReadBuffer>, p`
`48`	`49`	`clock_type = clock_type_;`
`49`	`50`	`}`
`50`	`51`
	`52`	`+ size_t getFileSize() override;`
	`53`	`+`
`51`	`54`	`protected:`
`52`	`55`	`std::optional<size_t> file_size;`
`53`	`56`	`ProfileCallback profile_callback;`