Skip to content

Commit 9fe9205

Browse files
usuraievillique
andauthored
Apply suggestions from code review
Co-authored-by: Nikolay Degterinsky <[email protected]>
1 parent 8076e1e commit 9fe9205

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/Functions/FunctionStartsEndsWith.h

+3-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ class FunctionStartsEndsWith : public IFunction
7070
if (isArray(arguments[0]) && isArray(arguments[1]))
7171
return std::make_shared<DataTypeUInt8>();
7272

73-
throw Exception("Illegal type " + arguments[0]->getName() + " of argument of function " + getName(), ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
73+
throw Exception(ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT,
74+
"Illegal types {} {} of arguments of function {}. Both must be String or Array",
75+
arguments[0]->getName(), arguments[1]->getName(), getName());
7476
}
7577

7678
ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr &, size_t input_rows_count) const override

src/Functions/GatherUtils/GatherUtils.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ enum class ArraySearchType
3535
Any, // Corresponds to the hasAny array function
3636
All, // Corresponds to the hasAll array function
3737
Substr, // Corresponds to the hasSubstr array function
38-
StartsWith, // TODO: EndsWith
38+
StartsWith,
3939
EndsWith
4040
};
4141

0 commit comments

Comments
 (0)