From 33f65c3ac4bf05e564b7a9f758aeecf4d960a658 Mon Sep 17 00:00:00 2001 From: Adam Spooner Date: Thu, 26 Sep 2019 14:37:31 -0400 Subject: [PATCH] Update delete modal. (#19697) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * WIP * WIP * WIP * Update text. * Remove from mobile, for now. * Update storyshots. * 🔥 * Review feedback. --- .../common-adapters/confirm-modal/index.tsx | 3 +- shared/constants/settings.tsx | 2 - shared/settings/delete-confirm/container.tsx | 17 +- shared/settings/delete-confirm/index.d.ts | 11 - .../settings/delete-confirm/index.desktop.tsx | 64 -- .../settings/delete-confirm/index.native.tsx | 5 - .../settings/delete-confirm/index.stories.tsx | 2 - shared/settings/delete-confirm/index.tsx | 114 +++ shared/settings/delete/container.tsx | 11 - shared/settings/delete/index.d.ts | 7 - shared/settings/delete/index.desktop.tsx | 34 - shared/settings/delete/index.native.tsx | 5 - shared/settings/delete/index.stories.tsx | 9 - shared/settings/index.stories.tsx | 2 - shared/settings/routes.desktop.tsx | 4 +- shared/settings/routes.native.tsx | 4 +- .../__snapshots__/Storyshots.test.js.snap | 728 +++++++++++------- 17 files changed, 581 insertions(+), 441 deletions(-) delete mode 100644 shared/settings/delete-confirm/index.d.ts delete mode 100644 shared/settings/delete-confirm/index.desktop.tsx delete mode 100644 shared/settings/delete-confirm/index.native.tsx create mode 100644 shared/settings/delete-confirm/index.tsx delete mode 100644 shared/settings/delete/container.tsx delete mode 100644 shared/settings/delete/index.d.ts delete mode 100644 shared/settings/delete/index.desktop.tsx delete mode 100644 shared/settings/delete/index.native.tsx delete mode 100644 shared/settings/delete/index.stories.tsx diff --git a/shared/common-adapters/confirm-modal/index.tsx b/shared/common-adapters/confirm-modal/index.tsx index 2747c51bc3b7..a6fb1a82cdc8 100644 --- a/shared/common-adapters/confirm-modal/index.tsx +++ b/shared/common-adapters/confirm-modal/index.tsx @@ -20,6 +20,7 @@ export type Props = { iconColor?: Styles.Color onCancel?: () => void onConfirm?: () => void + onConfirmDeactivated?: boolean prompt: React.ReactNode waitingKey?: string } @@ -64,7 +65,7 @@ class ConfirmModal extends React.PureComponent { )} { - const enableDeleteLater = Kb.useTimeout(() => props.setAllowDeleteAccount(true), 2000) - React.useEffect(() => { - props.setAllowDeleteAccount(false) - enableDeleteLater() - }, []) - return -} - export default Container.connect( state => { if (!state.config.username) { @@ -23,15 +12,13 @@ export default Container.connect( } return { - allowDeleteForever: state.settings.allowDeleteAccount, username: state.config.username, } }, dispatch => ({ onCancel: () => dispatch(RouteTreeGen.createNavigateUp()), onDeleteForever: () => dispatch(SettingsGen.createDeleteAccountForever()), - setAllowDeleteAccount: allow => dispatch(SettingsGen.createSetAllowDeleteAccount({allow})), }), (s, d, o: OwnProps) => ({...o, ...s, ...d}) -)(DeleteConfirmContainer) +)(DeleteConfirm) diff --git a/shared/settings/delete-confirm/index.d.ts b/shared/settings/delete-confirm/index.d.ts deleted file mode 100644 index 3f35c78e9d17..000000000000 --- a/shared/settings/delete-confirm/index.d.ts +++ /dev/null @@ -1,11 +0,0 @@ -import {Component} from 'react' - -export type Props = { - username: string - allowDeleteForever: boolean - setAllowDeleteAccount: (allow: boolean) => void - onCancel: () => void - onDeleteForever: () => void -} - -export default class DeleteConfirm extends Component {} diff --git a/shared/settings/delete-confirm/index.desktop.tsx b/shared/settings/delete-confirm/index.desktop.tsx deleted file mode 100644 index b056de397477..000000000000 --- a/shared/settings/delete-confirm/index.desktop.tsx +++ /dev/null @@ -1,64 +0,0 @@ -import * as React from 'react' -import * as Styles from '../../styles' -import {Box, Button, Icon, Text, Avatar, ButtonBar} from '../../common-adapters' - -import {Props} from './index' - -function DeleteConfirm(props: Props) { - return ( - - - - - - {props.username} - - - Are you sure you want to permanently delete your account? - - -