Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.1.6 contains breaking change #6

Closed
sosthene-nitrokey opened this issue Nov 15, 2023 · 2 comments
Closed

Release 0.1.6 contains breaking change #6

sosthene-nitrokey opened this issue Nov 15, 2023 · 2 comments

Comments

@sosthene-nitrokey
Copy link

sosthene-nitrokey commented Nov 15, 2023 •
edited
Loading

Hi,

In release 0.1.6 you updated the version of usb-device to 0.3.0. However this is a breaking change because usb-device is part of the public API (since UsbIpBus implements usb_device::UsbBus).

This means that someone depending on usbip-device = "0.1.5" and usb-device = "0.2.9" will end up with incompatible implementations since cargo will download version0.1.6 of usbip-device.

The path to fixing this issue would be to:

  1. Yank the release 0.1.6
  2. Release the current 0.1.6 as 0.2.0, reflecting the breaking change into the version number

Thanks.
@sosthene-nitrokey sosthene-nitrokey changed the title Release 1.6.0 contains breaking change Release 0.1.6 contains breaking change Nov 15, 2023
@Sawchord
Copy link
Owner

Just updated. Thanks for catching this

@sosthene-nitrokey
Copy link
Author

Thank you very much for the quick handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sawchord @sosthene-nitrokey