Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Wall/Rampart building code gets stuck on impossible to built positions #254

Open
tedivm opened this issue Nov 27, 2017 · 0 comments · May be fixed by #440
Open

[bug] Wall/Rampart building code gets stuck on impossible to built positions #254

tedivm opened this issue Nov 27, 2017 · 0 comments · May be fixed by #440

Comments

@tedivm
Copy link
Contributor

tedivm commented Nov 27, 2017

This is primarily an issue because of another already solved bug, but it should still be resolved for robustness.

Basically, if a rampart or wall is scheduled to be built but it is in an impossible to build on position it will attempt to add the construction site and fail. The next tick it will see that there is no site there and will try again.

This can be resolved by adding a check when looking for "gaps" to see if it is possible to construct and then skipping over those that aren't.

@alexanselmo alexanselmo linked a pull request Nov 29, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant