From 90f3d8f7caa1423f1885874b50ffd52c0359dfb9 Mon Sep 17 00:00:00 2001
From: Tropical <42101043+Tropix126@users.noreply.github.com>
Date: Tue, 6 Apr 2021 13:07:30 -0500
Subject: [PATCH] fix spacebar firing `change` event twice

---
 src/renderer/common/Checkbox.svelte | 5 +++--
 src/renderer/stores/controls.js     | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/renderer/common/Checkbox.svelte b/src/renderer/common/Checkbox.svelte
index 6402971e..291ebd0a 100644
--- a/src/renderer/common/Checkbox.svelte
+++ b/src/renderer/common/Checkbox.svelte
@@ -1,5 +1,6 @@
 <script>
-    import {handleKeyboardToggle} from "../stores/controls.js";
+    // NOTES: preventing the default click event behavior is needed to stop the change event being fired twice when the spacebar is pressed.
+    import {handleKeyboardToggle, checkItem} from "../stores/controls.js";
 
     export let label;
     export let checked = false;
@@ -8,7 +9,7 @@
     let checkbox;
 </script>
 
-<div class="checkbox" on:keypress={handleKeyboardToggle(checkbox)}>
+<div class="checkbox" on:keypress={handleKeyboardToggle(checkbox)} on:click={checkItem(checkbox)}>
     <label>
         <input type="checkbox" {disabled} bind:this={checkbox} bind:checked on:change>
         {#if label}
diff --git a/src/renderer/stores/controls.js b/src/renderer/stores/controls.js
index 1483b5f0..5cb0d75b 100644
--- a/src/renderer/stores/controls.js
+++ b/src/renderer/stores/controls.js
@@ -4,14 +4,14 @@ export const radioSelectedIndex = writable(0);
 
 let i = 0;
 
-function checkItem(item) {
+export function checkItem(item) {
     item.checked = !item.checked;
     const changeEvent = new Event("change");
     item.dispatchEvent(changeEvent);
 }
 
 export const handleKeyboardToggle = (checkbox) => {
-    if ((event.key === "Enter" || event.key === " ") && checkbox.disabled != true) {
+    if ((event.key === "Enter" || event.key === " ") && !checkbox.disabled) {
         checkItem(checkbox);
     }
 };