Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] support for all sqlite file extensions #31

Open
Shivansh-yadav13 opened this issue Oct 20, 2022 · 1 comment
Open

[feat] support for all sqlite file extensions #31

Shivansh-yadav13 opened this issue Oct 20, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Eligible for Hacktoberfest Hacktoberfest 2022

Comments

@Shivansh-yadav13
Copy link
Owner

Issue
Sqlite database support the following file extensions
.sqlite, .sqlite3, .db, .db3, .s3db, .sl3
but sqlite-ui can only open files with .db extension.

Solution
Make the db uri flexible and allow the users to pass in file name along with the extension

db.ConnectDB(fmt.Sprintf("./sqlite_database/%s.db", dbName))

@Shivansh-yadav13 Shivansh-yadav13 added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Eligible for Hacktoberfest Hacktoberfest 2022 labels Oct 20, 2022
@Shivansh-yadav13 Shivansh-yadav13 pinned this issue Oct 20, 2022
@wliao008
Copy link
Collaborator

@Shivansh-yadav13 i'd propose to make this simpler, by passing in the complete path to the db file instead, so basically the db file can be named whatever and located in any directory and it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Eligible for Hacktoberfest Hacktoberfest 2022
Projects
None yet
Development

No branches or pull requests

2 participants