Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sk_path to metadata structure #327

Open
joelkoz opened this issue Dec 15, 2020 · 1 comment
Open

Add sk_path to metadata structure #327

joelkoz opened this issue Dec 15, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@joelkoz
Copy link
Collaborator

joelkoz commented Dec 15, 2020

For SensESP v2.0: if we add sk_path as a member of SKMetadata we can combine two of the three parameters to the constructor of that class. We then start moving toward specifying sk_path not with a String, but with SKMetadata. We could even deprecate all versions of constructors that take sk_path as a String. What this would do is strongly type the sk_path as a complex Signal K definition, and not just any old String

@joelkoz joelkoz added the enhancement New feature or request label Dec 15, 2020
@ba58smith
Copy link
Collaborator

Would it, though? (Strongly type the sk_path.) It's still going to be defined as a string (lowercase) within SKMetadata, isn't it? What's to prevent someone from just making up a path, same as they do now?

SKMetadata* metadata = new SKMetadata();
  metadata->sk_path_ = "whatever.i.feel.like";

@joelkoz joelkoz changed the title ENH: Add sk_path to metadata structure Add sk_path to metadata structure Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants