Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ClickType with sealed type and records #176

Open
Sparky983 opened this issue Sep 20, 2023 · 0 comments
Open

Replace ClickType with sealed type and records #176

Sparky983 opened this issue Sep 20, 2023 · 0 comments
Assignees
@Sparky983
Labels
breaking Introduces a breaking change enhancement New feature or request
Milestone
2.0

Comments

@Sparky983
Copy link
Owner

Motivation

It's currently impossible to which number key was used with for ClickType.NUMBER_KEY clicks.

Alternatives

An int number() could simply be added to Click, however that would not be type safe.
@Sparky983 Sparky983 added the enhancement New feature or request label Sep 20, 2023
@Sparky983 Sparky983 added this to the 1.1 milestone Sep 20, 2023
@Sparky983 Sparky983 self-assigned this Sep 20, 2023
@Sparky983 Sparky983 modified the milestones: 1.1, 2.0 Oct 28, 2023
@Sparky983 Sparky983 added the breaking Introduces a breaking change label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sparky983 Sparky983

Labels
breaking Introduces a breaking change enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@Sparky983