Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_directions(); Valid names for waypoints list #12

Closed
jonocarroll opened this issue Jun 16, 2016 · 1 comment
Closed

google_directions(); Valid names for waypoints list #12

jonocarroll opened this issue Jun 16, 2016 · 1 comment
Milestone

Comments

@jonocarroll
Copy link

In google_directions(), while it is already noted that lists with elements named via will be processed as non-stopping waypoints, it took hunting through the source code to realise that they need to be named "" (explicitly empty character) to be used otherwise. You have fatal testing for this in-place, but it's not documented.

Given that you explicitly write the via: prefix anyway, I'd like to suggest adding stop to the list of valid names in your package, which can then be left out from the actual API call.

@SymbolixAU SymbolixAU self-assigned this Jun 19, 2016
@SymbolixAU SymbolixAU added this to the 1.2.0 milestone Jun 19, 2016
@SymbolixAU
Copy link
Collaborator

Good spot. I'll add a fix for the next release.

@SymbolixAU SymbolixAU removed their assignment Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant