Fix object hashing in schema

SymbolixAU · Sep 28, 2023 · eee82cb · eee82cb
1 parent b4a6da3
commit eee82cb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/include/rapidjson/schema.h b/include/rapidjson/schema.h
@@ -367,7 +367,9 @@ class Hasher {
         uint64_t h = Hash(0, kObjectType);
         uint64_t* kv = stack_.template Pop<uint64_t>(memberCount * 2);
         for (SizeType i = 0; i < memberCount; i++)
-            h ^= Hash(kv[i * 2], kv[i * 2 + 1]);  // Use xor to achieve member order insensitive
+            // Issue #2205
+            // Hasing the key to avoid key=value cases with bug-prone zero-value hash
+            h ^= Hash(Hash(0, kv[i * 2]), kv[i * 2 + 1]);  // Use xor to achieve member order insensitive
         *stack_.template Push<uint64_t>() = h;
         return true;
     }