Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pluggable classloaders for AnnotationFrameFactory #39

Open
jsight opened this issue Jan 2, 2018 · 5 comments
Open

Support pluggable classloaders for AnnotationFrameFactory #39

jsight opened this issue Jan 2, 2018 · 5 comments

Comments

@jsight
Copy link
Contributor

jsight commented Jan 2, 2018

Right now, this relies on the context classloader, but I would like to provide my own implementation for use by ByteBuddy.

@freemo
Copy link
Member

freemo commented Jan 3, 2018 via email

@ghost
Copy link

ghost commented Jan 4, 2018

If I can help you I'll do it just let me know ✋ @jsight

@jsight
Copy link
Contributor Author

jsight commented Jan 4, 2018

I can try to put together a PR with a few things like this that I have run into. I am currently working on migrating https://github.com/windup/windup to Ferma from Tinkerpop 2 and a forked version of frames.

@freemo
Copy link
Member

freemo commented Jan 4, 2018

@jsight Any reason your using a forked version of frames rather than Ferma? I tried to make Ferma very close to Frames for compatibility reasons.

I can obviously help with the PR if anyone needs it. If no one gets to it ill try to add it myself when I have time. Very much appreciate all the help.

@jsight
Copy link
Contributor Author

jsight commented Jan 9, 2018

#42

We used a forked version of Frames because we had started with Frames before Ferma existed. We also use a lot of really esoteric functionality for various historical reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants